From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present
Date: Fri, 29 Sep 2006 15:49:17 -0700 (PDT) [thread overview]
Message-ID: <20060929.154917.125894679.davem@davemloft.net> (raw)
In-Reply-To: <1159565963.3741.23.camel@rh4>
From: "Michael Chan" <mchan@broadcom.com>
Date: Fri, 29 Sep 2006 14:39:23 -0700
> On Fri, 2006-09-29 at 17:28 -0400, Jeff Garzik wrote:
> > Michael Chan wrote:
> > > AMD believes this incompatibility is unique to the 5706, and
> > > prefers to locally disable MSI rather than globally disabling it
> > > using pci_msi_quirk.
> >
> > Why is it unique to the 5706? Is this just a guess on AMD and
> > Broadcom's part?
> >
> I just took AMD's word for it. It doesn't matter to me whether we
> disable it locally or globally. Since this is AMD's bridge, I just
> follow their recommendation. They probably haven't seen this issue on
> any other devices except ours.
I really think this is a reasonable thing to do.
It's absolutely rediculious to disable MSI for every card just
because one decided to use a masked 64-bit transaction for
what's supposed to be a 32-bit one.
Jeff, I totally understand your knee-jerk reaction to per-device MSI
validation checks, but in this case I find that knee-jerk reaction
to be totally unreasonable. :-)
next prev parent reply other threads:[~2006-09-29 22:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 21:07 [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present Michael Chan
2006-09-29 21:28 ` Jeff Garzik
2006-09-29 21:39 ` Michael Chan
2006-09-29 22:49 ` David Miller [this message]
2006-09-29 23:00 ` Jeff Garzik
2006-09-29 23:08 ` David Miller
2006-09-29 23:15 ` Jeff Garzik
2006-09-29 23:27 ` Michael Chan
2006-09-29 23:29 ` David Miller
2006-09-30 0:38 ` Jeff Garzik
2006-09-30 1:22 ` David Miller
2006-09-29 23:46 ` Rick Jones
2006-09-30 0:16 ` Roland Dreier
2006-09-30 0:07 ` David Miller
2006-09-30 10:13 ` Brice Goglin
2006-09-30 18:09 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060929.154917.125894679.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).