From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org, dccp@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
"David S. Miller" <davem@davemloft.net>,
Pekka Savola <pekkas@netcore.fi>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@coreworks.de>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH] IPv6/DCCP: Fix memory leak in dccp_v6_do_rcv()
Date: Fri, 29 Sep 2006 02:45:33 +0200 [thread overview]
Message-ID: <200609290245.33618.jesper.juhl@gmail.com> (raw)
Coverity found what looks like a real leak in net/dccp/ipv6.c::dccp_v6_do_rcv()
We may leave via the return inside "if (sk->sk_state == DCCP_OPEN) {"
but at that point we may have allocated opt_skb, but we never free it
in that path before the return.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
net/dccp/ipv6.c | 2 ++
1 file changed, 2 insertions(+)
--- linux-2.6.18-git10-orig/net/dccp/ipv6.c 2006-09-28 22:40:07.000000000 +0200
+++ linux-2.6.18-git10/net/dccp/ipv6.c 2006-09-29 02:35:15.000000000 +0200
@@ -997,6 +997,8 @@ static int dccp_v6_do_rcv(struct sock *s
if (sk->sk_state == DCCP_OPEN) { /* Fast path */
if (dccp_rcv_established(sk, skb, dccp_hdr(skb), skb->len))
goto reset;
+ if (opt_skb)
+ __kfree_skb(opt_skb);
return 0;
}
PS. Please keep me on Cc:
--
Jesper Juhl <jesper.juhl@gmail.com>
next reply other threads:[~2006-09-29 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 0:45 Jesper Juhl [this message]
2006-09-29 6:07 ` [PATCH] IPv6/DCCP: Fix memory leak in dccp_v6_do_rcv() Andrew Morton
2006-09-29 10:02 ` [PATCH] IPv6/DCCP: Remove unused IPV6_PKTOPTIONS code Gerrit Renker
2006-09-29 14:40 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609290245.33618.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=jmorris@namei.org \
--cc=kaber@coreworks.de \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).