From: Stephen Hemminger <shemminger@osdl.org>
To: olivier.crameri@epfl.ch
Cc: olivier.crameri@gmail.com, netdev@vger.kernel.org,
"Yoshio Turner" <yoshiotu@hpl.hp.com>,
"Santos, Jose Renato G" <joserenato.santos@hp.com>,
"Janakiraman, John" <john.janakiraman@hp.com>
Subject: Re: Offloading features in VLAN interfaces
Date: Fri, 29 Sep 2006 20:33:34 -0700 [thread overview]
Message-ID: <20060929203334.6ac78838@localhost.localdomain> (raw)
In-Reply-To: <b54af0b00609291725t55ac0a84pf86525ef0a31f44e@mail.gmail.com>
On Fri, 29 Sep 2006 17:25:35 -0700
"Olivier Crameri" <olivier.crameri@gmail.com> wrote:
> Same thing but with the patch this time.
>
> Sorry about that,
> Olivier Crameri
>
> On 9/29/06, Olivier Crameri <olivier.crameri@gmail.com> wrote:
> > Hi,
> >
> > after running some experiments, we realised that using VLAN support in
> > Linux caused some overhead. It turned out to be that the offloading
> > features of our NIC (tso, sg, checksum offloading) were not beeing
> > used.
> >
> > After digging a little bit in the code, we realised that the VLAN code
> > did not set the features parameter of the net_device structure for the
> > virtual interface. Attached is a patch with a suggested solution to
> > this problem.
> >
> > Please let us know if this is an acceptable patch.
> >
> > Thanks,
> > Olivier Crameri, HP Labs
> >
Patch needs to include "Developer's Certificate of Origin"
see Documentation/SubmittingPatches section 11.
Patch should not be sent as an attachment (if at all possible).
Skip the marque comment. It is standard practice now to use the revision
control system change log for attribution.
Please handle all the current offload features including GSO.
next prev parent reply other threads:[~2006-09-30 3:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-30 0:21 Offloading features in VLAN interfaces Olivier Crameri
2006-09-30 0:25 ` Olivier Crameri
2006-09-30 3:33 ` Stephen Hemminger [this message]
2006-10-05 16:25 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060929203334.6ac78838@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=john.janakiraman@hp.com \
--cc=joserenato.santos@hp.com \
--cc=netdev@vger.kernel.org \
--cc=olivier.crameri@epfl.ch \
--cc=olivier.crameri@gmail.com \
--cc=yoshiotu@hpl.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).