From: David Miller <davem@davemloft.net>
To: jeff@garzik.org
Cc: per.liden@ericsson.com, jon.maloy@ericsson.com,
allan.stephens@windriver.com, akpm@osdl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TIPC: fix printk warning
Date: Tue, 03 Oct 2006 16:25:44 -0700 (PDT) [thread overview]
Message-ID: <20061003.162544.125897847.davem@davemloft.net> (raw)
In-Reply-To: <20061001162413.GA8000@havoc.gtf.org>
From: Jeff Garzik <jeff@garzik.org>
Date: Sun, 1 Oct 2006 12:24:13 -0400
> gcc spits out this warning:
>
> net/tipc/link.c: In function ^[$,1rx^[(Blink_retransmit_failure^[$,1ry^[(B:
> net/tipc/link.c:1669: warning: cast from pointer to integer of different
> size
>
> More than a little bit ugly, storing integers in void*, but at least the
> code is correct, unlike some of the more crufty Linux kernel code found
> elsewhere.
>
> Rather than having two casts to massage the value into u32, it's easier
> just to have a single cast and use "%lu", since it's just a printk.
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Applied, thanks Jeff.
prev parent reply other threads:[~2006-10-03 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 16:24 [PATCH] TIPC: fix printk warning Jeff Garzik
2006-10-03 23:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061003.162544.125897847.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=allan.stephens@windriver.com \
--cc=jeff@garzik.org \
--cc=jon.maloy@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=per.liden@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).