From: Ralf Baechle <ralf@linux-mips.org>
To: Andrew Morton <akpm@osdl.org>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
Jeff Garzik <jgarzik@pobox.com>,
Andy Fleming <afleming@freescale.com>,
netdev@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [patch 4/6] 2.6.18: sb1250-mac: The actual driver update
Date: Wed, 4 Oct 2006 02:10:46 +0100 [thread overview]
Message-ID: <20061004011046.GA10247@linux-mips.org> (raw)
In-Reply-To: <20061003164253.62f9d5a3.akpm@osdl.org>
On Tue, Oct 03, 2006 at 04:42:53PM -0700, Andrew Morton wrote:
> On Tue, 3 Oct 2006 16:18:44 +0100 (BST)
> "Maciej W. Rozycki" <macro@linux-mips.org> wrote:
>
> > + sbmac_state_t sbm_state; /* current state */
>
> argh.
>
> The reader looks at this and doesn't know if it's an integer, a void*, a
> struct usb_ac_header_descriptor** or what.
>
> enum sbmac_state smb_state;
>
> is nicer. It has information.
De-typedef-ing would be a separate project for this driver which makes
quite generous use of typedefs.
Ralf
prev parent reply other threads:[~2006-10-04 1:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 15:18 [patch 4/6] 2.6.18: sb1250-mac: The actual driver update Maciej W. Rozycki
2006-10-03 23:42 ` Andrew Morton
2006-10-04 1:10 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061004011046.GA10247@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=afleming@freescale.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).