From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivo van Doorn Subject: Re: d80211: ieee80211_hw handlers in atomic context Date: Wed, 4 Oct 2006 18:34:57 +0200 Message-ID: <200610041834.57918.IvDoorn@gmail.com> References: <4523DA7D.2080604@web.de> <200610041807.05266.IvDoorn@gmail.com> <4523E1D5.1060505@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: Jiri Benc , netdev Return-path: Received: from nf-out-0910.google.com ([64.233.182.189]:31218 "EHLO nf-out-0910.google.com") by vger.kernel.org with ESMTP id S1161540AbWJDQfv (ORCPT ); Wed, 4 Oct 2006 12:35:51 -0400 Received: by nf-out-0910.google.com with SMTP id x30so533830nfb for ; Wed, 04 Oct 2006 09:35:49 -0700 (PDT) To: Jan Kiszka In-Reply-To: <4523E1D5.1060505@web.de> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wednesday 04 October 2006 18:31, Jan Kiszka wrote: > Ivo van Doorn wrote: > > Hi, > > > >> Ivo told me about a patch for d80211 that moved certain timers to thread > >> context, effectively avoiding to call config from timer handlers, but I > >> didn't find any trace yet. Is there some modification in this direction > >> already scheduled? I'm not necessarily looking for work, at best I would > >> just enjoy to use it. ;) > > > > I have found the actual patch: > > [PATCH 1/5] d80211: make sleeping in hw->config possible > > And was send on august 1st by Jiri to the netdev list. > > It was based on a patch by Michael Buesch. > > Ah, looks like I didn't dug thoroughly enough. > > Anyway, this means my BUG proved the patch's claim wrong :o), at least > one atomic gremlin is left: > > ieee80211_sta_timer -> > ieee80211_sta_find_ibss -> > ieee80211_sta_join_ibss -> > ieee80211_ioctl_siwfreq -> > ieee80211_hw_config > > Anyone already an idea how to fix it? You could replace the timer with a workqueue, the original patch also did that, so I think it would be good enough this time as well. :) Ivo