From: David Miller <davem@davemloft.net>
To: jmorris@namei.org
Cc: vyekkirala@trustedcs.com, paul.moore@hp.com,
netdev@vger.kernel.org, selinux@tycho.nsa.gov, sds@tycho.nsa.gov,
eparis@redhat.com, johnpol@2ka.mipt.ru,
herbert@gondor.apana.org.au
Subject: Re: [PATCH 1/3] Fix for IPsec leakage with SELinux enabled - V.03
Date: Thu, 05 Oct 2006 14:04:23 -0700 (PDT) [thread overview]
Message-ID: <20061005.140423.48528368.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0610051651580.25705@d.namei>
From: James Morris <jmorris@namei.org>
Date: Thu, 5 Oct 2006 16:54:38 -0400 (EDT)
> > #ifdef CONFIG_XFRM_SUB_POLICY
> > pol = xfrm_policy_lookup_bytype(XFRM_POLICY_TYPE_SUB, fl, family, dir);
> > - if (pol)
> > + if (IS_ERR(pol)) {
> > + err = PTR_ERR(pol);
> > + pol = NULL;
> > + }
> > + if (pol || err)
> > goto end;
>
> Similarly, if the sub-policy lookup returns -EACCESS, should we then try a
> main policy lookup before failing?
We're trying to fill the flow cache here. In the case where we'd
have a match in both the sub-policy and main table, I think the
sub-policy is supposed to take precedence, and if you fail to get
this sub-policy you should fail the entire lookup.
The way the sub-policied entries work is that you find the sub-policy
as the primary object in the flow cache, and once you notice you have
a sub-policy you do an explicit lookup in the main table to put the
whole thing together.
next prev parent reply other threads:[~2006-10-05 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 20:42 [PATCH 1/3] Fix for IPsec leakage with SELinux enabled - V.03 Venkat Yekkirala
2006-10-05 20:54 ` James Morris
2006-10-05 21:04 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-05 21:17 Venkat Yekkirala
2006-10-05 23:30 ` James Morris
2006-10-05 21:27 Venkat Yekkirala
2006-10-05 21:47 ` David Miller
2006-10-05 23:05 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061005.140423.48528368.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=johnpol@2ka.mipt.ru \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=vyekkirala@trustedcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).