From: Pavel Machek <pavel@ucw.cz>
To: Dave Kleikamp <shaggy@austin.ibm.com>
Cc: Adrian Bunk <bunk@stusta.de>,
Alex Romosan <romosan@sycorax.lbl.gov>,
linux-kernel@vger.kernel.org, linville@tuxdriver.com,
netdev@vger.kernel.org, linux-pm@osdl.org
Subject: Re: 2.6.19-rc1 regression: airo suspend fails
Date: Sun, 8 Oct 2006 08:43:03 +0200 [thread overview]
Message-ID: <20061008064303.GA3111@elf.ucw.cz> (raw)
In-Reply-To: <1160250771.24902.6.camel@kleikamp.austin.ibm.com>
Hi!
> > > it breaks suspend when the airo module is loaded:
> > >
> > > kernel: Stopping tasks: =================================================================================
> > > kernel: stopping tasks timed out after 20 seconds (1 tasks remaining):
> > > kernel: eth1
> > > kernel: Restarting tasks...<6> Strange, eth1 not stopped
> > >
> > > if i remove the airo module suspend works normally (this is on a
> > > thinkpad t40).
> >
> > Thanks for your report.
> >
> > Let's try to figure out what broke it.
>
> I believe it was broken by:
> http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3b4c7d640376dbccfe80fc4f7b8772ecc7de28c5
>
> I have seen this in the -mm tree, but didn't follow up at the time. I
> was able to fix it with the following patch. I don't know if it's the
> best fix, but it seems to follow the same logic as the original code.
>
>
> The airo driver used to break out of while loop if there were any signals
> pending. Since it no longer checks for signals, it at least needs to check
> if it needs to be frozen.
>
> Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>
ACK. Please push it to akpm or airo maintainers...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2006-10-08 6:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0610042017340.3952@g5.osdl.org>
[not found] ` <871wpmoyjv.fsf@sycorax.lbl.gov>
2006-10-06 18:47 ` 2.6.19-rc1 regression: airo suspend fails Adrian Bunk
2006-10-07 3:54 ` Alex Romosan
2006-10-07 19:52 ` Dave Kleikamp
2006-10-07 20:17 ` Alex Romosan
2006-10-08 6:43 ` Pavel Machek [this message]
2006-10-07 21:46 ` 2.6.19-rc1: known regressions (v2) Adrian Bunk
2006-10-08 8:56 ` matthieu castet
2006-10-09 15:32 ` 2.6.19-rc1: known regressions (v2) - xfrm_register_mode Steve Fox
2006-10-09 15:51 ` Mel Gorman
2006-10-10 5:10 ` 2.6.19-rc1: known regressions (v3) Adrian Bunk
2006-10-10 22:58 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061008064303.GA3111@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@osdl.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=romosan@sycorax.lbl.gov \
--cc=shaggy@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).