cfg80211 take 7

cfg80211 take 7

[Johannes Berg]

Hah, take 6 was eaten by netdev (even the announcement) but it did reach
some people (and before those who did get it wonder: I resent to netdev,
the original mail was accidentally not addressed to netdev, so it's not
that I simply didn't send it).

anyway, it's getting large, so... straight from quilt:
http://johannes.sipsolutions.net/files/cfg80211/

order is:
nl80211.patch
move-wext.patch
wext-compat.patch

johannes

Re: cfg80211 take 7

[Johannes Berg]

Maybe this time it'll take the announcement too?
---
I have
 * addressed Dan's comments about naming a few things and
   also fixed the problems he pointed out
 * moved wext from net/core/wireless.c to net/wireless/wext-old.c
 * added compat hunking for WE to cfg80211, finally completely
   separating the userspace interface and the internal interface
 * made it possible to port drivers to cfg80211 call by call!  
 * fixed a bug with locking in core.c

I have not
 * added get_scan
 * added event notification

Have fun. Oh, I can put this into a git tree too if you think that'd be
useful for further collaboration. However, I'm thinking that wireless-dev
could also be used since this doesn't really break anything, it just adds
new code that might not be in use yet, but should be fairly good to use  
should anyone want that.

I guess what I'm trying to say with that is that there's no way I can finish
this all by myself, I also need sleep sometimes ;) I thank everyone for
their review and suppose that more people read it than commented (which is
probably a good thing). Hopefully I can motivate you with these patches that
should ease migration to actually help with code as well :)

johannes

Re: cfg80211 take 7

[Stefan Rompf]

Am Freitag, 6. Oktober 2006 16:59 schrieben Sie:

> anyway, it's getting large, so... straight from quilt:
> http://johannes.sipsolutions.net/files/cfg80211/

nice work! Is there any possibility to limit the card to a specific band (e.g. 
802.11 a/b/g) using cfg80211? I'm asking because I haven't seen code to 
accomplish this in cfg80211, but I maybe wrong.

Many drivers implement this feature as an iwpriv, and I consider it useful 
enough (especially when association and roaming is kernel controlled) to 
justify a generic configuration element.

Thoughts?

Stefan

Re: cfg80211 take 7

[Johannes Berg]

On Mon, 2006-10-09 at 13:22 +0200, Stefan Rompf wrote:

> nice work! Is there any possibility to limit the card to a specific band (e.g. 
> 802.11 a/b/g) using cfg80211? I'm asking because I haven't seen code to 
> accomplish this in cfg80211, but I maybe wrong.

Never really thought about that, so the answer for now is "no" :) Should
be easy to add though if we figure out what exactly we want/need.

> Many drivers implement this feature as an iwpriv, and I consider it useful 
> enough (especially when association and roaming is kernel controlled) to 
> justify a generic configuration element.

Yeah, probably makes sense. Though, maybe not just the band but a set of
channels instead?

johannes

Re: cfg80211 take 7

[Stefan Rompf]

Am Montag, 9. Oktober 2006 13:49 schrieb Johannes Berg:

> Yeah, probably makes sense. Though, maybe not just the band but a set of
> channels instead?

Yes, this would allow us to keep the definition of a band out of kernel. But 
to distinguish between 802.11 b and g, we'd need a set of channels and 
allowed modulations. I haven't looked at Larry's regulatory domain stuff yet, 
but maybe band selection could use the same data structure. cfg80211 would 
then just calculate the intersection of user supplied set and set permitted 
by regulations.

Hopefully there is no country that forbids the user *NOT* to scan a specific 
channel ;)

Stefan

Re: cfg80211 take 7

[Larry Finger]

Stefan Rompf wrote:
> Am Montag, 9. Oktober 2006 13:49 schrieb Johannes Berg:
> 
>> Yeah, probably makes sense. Though, maybe not just the band but a set of
>> channels instead?
> 
> Yes, this would allow us to keep the definition of a band out of kernel. But 
> to distinguish between 802.11 b and g, we'd need a set of channels and 
> allowed modulations. I haven't looked at Larry's regulatory domain stuff yet, 
> but maybe band selection could use the same data structure. cfg80211 would 
> then just calculate the intersection of user supplied set and set permitted 
> by regulations.
> 
> Hopefully there is no country that forbids the user *NOT* to scan a specific 
> channel ;)
> 

Passive scanning is always allowed, AFAIK. Active scanning is a different matter. In the US, no one 
is allowed to active scan channels 12-14. In addition, there are a number of countries where the 
regulations prohibit active scanning in some or all of the 5 GHz bands.

Larry

Re: cfg80211 take 7

[David Kimdon]

FYI, all three patches mentioned as possibly required by the nl80211
patchset in the header of nl80211.patch are already in wireless-dev:

http://marc.theaimsgroup.com/?l=linux-netdev&m=115625436628696&w=2
(Introduces NLA_NUL_STRING) 

http://marc.theaimsgroup.com/?l=linux-netdev&m=115625168405439&w=2
(Convert existing NLA_STRING attributes to use the new validation
features)

http://marc.theaimsgroup.com/?l=linux-netdev&m=115650333420169&w=2
(remove value argument from NLA_PUT_FLAG)

I also updated the patchset a bit to apply to current wireless-dev.
I will send that to Johannes directly.



On Fri, Oct 06, 2006 at 04:59:50PM +0200, Johannes Berg wrote:
> Hah, take 6 was eaten by netdev (even the announcement) but it did reach
> some people (and before those who did get it wonder: I resent to netdev,
> the original mail was accidentally not addressed to netdev, so it's not
> that I simply didn't send it).
> 
> anyway, it's getting large, so... straight from quilt:
> http://johannes.sipsolutions.net/files/cfg80211/
> 
> order is:
> nl80211.patch
> move-wext.patch
> wext-compat.patch
> 
> johannes
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: cfg80211 take 7

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

On Mon, 2006-10-09 at 11:38 -0700, David Kimdon wrote:
> FYI, all three patches mentioned as possibly required by the nl80211
> patchset in the header of nl80211.patch are already in wireless-dev:

Oh, nice, I must have missed the merge :)

> I also updated the patchset a bit to apply to current wireless-dev.
> I will send that to Johannes directly.

Cool, thanks.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]