From: David Miller <davem@davemloft.net>
To: gerrit@erg.abdn.ac.uk
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH-update][RFC] net: consolidated UDP / UDP-Lite code
Date: Tue, 10 Oct 2006 19:38:28 -0700 (PDT) [thread overview]
Message-ID: <20061010.193828.10132678.davem@davemloft.net> (raw)
In-Reply-To: <200610091051.45021@strip-the-willow>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Mon, 9 Oct 2006 10:51:44 +0100
> csum_copy_err:
> - UDP_INC_STATS_BH(UDP_MIB_INERRORS);
> + UDP_INC_STATS_BH(UDP_MIB_INERRORS, is_udplite);
> + UDP_DEC_STATS_BH(UDP_MIB_INDATAGRAMS, is_udplite);
I'm not a big fan at all of these "statistic corrections"
we're starting to place in various spots.
I really don't think it's the end of the world if we count as
INDATAGRAMS a packet that we later discover has a bad checksum.
There are even some serious issues to consider because we might,
for example, count the INDATAGRAMS on a particular cpu, and then
find the checksum problem on another cpu and thus be subtracting
a different one of the per-cpu instances of this counter. That
could make it negative or similar.
next prev parent reply other threads:[~2006-10-11 2:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-14 16:19 [PATCHv2 2.6.18-rc1-mm2 1/3] net: UDP-Lite generic support Gerrit Renker
2006-07-15 13:33 ` Herbert Xu
2006-07-16 9:29 ` Gerrit Renker
2006-07-28 5:30 ` David Miller
2006-07-28 8:19 ` Gerrit Renker
2006-07-28 8:25 ` David Miller
2006-09-19 7:25 ` [PATCHv3 1/4][RFC] net/ipv4: consolidated UDP / UDP-Lite code Gerrit Renker
2006-10-09 9:51 ` [PATCH-update][RFC] net: " Gerrit Renker
2006-10-11 2:38 ` David Miller [this message]
2006-10-11 7:40 ` Gerrit Renker
2006-10-12 7:49 ` Gerrit Renker
2006-10-12 9:01 ` David Miller
2006-10-13 15:14 ` [PATCHv4 1/3] net/ipv4: UDP-Lite support (RFC 3828) Gerrit Renker
2006-10-13 15:14 ` [PATCHv4 2/3] net/ipv6: v6-side of UDP-Lite Gerrit Renker
2006-10-13 15:14 ` [PATCHv4 3/3] net: UDP-Lite misc files Gerrit Renker
2006-09-19 7:25 ` [PATCHv3 2/4][RFC] net/ipv4: self-contained UDP-Lite module Gerrit Renker
2006-09-19 7:25 ` [PATCHv3 3/4][RFC] net: basic xfrm/netfilter support for UDP-Lite Gerrit Renker
2006-09-19 7:37 ` Patrick McHardy
2006-09-19 7:25 ` [PATCHv3 4/4][RFC] net: misc. files to support UDP-Lite Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010.193828.10132678.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).