From: David Miller <davem@davemloft.net>
To: woodard@redhat.com
Cc: netdev@vger.kernel.org, mgrondona@llnl.gov, behlendorf1@llnl.gov
Subject: Re: [PATCH] Customizable TCP backoff patch
Date: Tue, 10 Oct 2006 19:53:41 -0700 (PDT) [thread overview]
Message-ID: <20061010.195341.32721754.davem@davemloft.net> (raw)
In-Reply-To: <452C4D12.9060102@redhat.com>
From: Ben Woodard <woodard@redhat.com>
Date: Tue, 10 Oct 2006 18:46:58 -0700
> @@ -257,6 +259,8 @@
> __u8 frto_counter; /* Number of new acks after RTO */
> __u8 nonagle; /* Disable Nagle algorithm? */
> __u8 keepalive_probes; /* num of allowed keep alive probes */
> + __u16 rto_max; /* Maximum backoff value in ms */
> + __u16 rto_init; /* Initial backoff value in ms */
The existing struct members are properly indented using tabs,
your patch adds members which are indented using spaces. Please
fix this, thanks a lot.
next prev parent reply other threads:[~2006-10-11 2:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-27 18:52 [PATCH] Customizable TCP backoff patch Ben Woodard
2006-09-27 23:16 ` David Miller
2006-09-27 23:00 ` Stephen Hemminger
2006-09-28 2:06 ` David Miller
2006-10-03 18:14 ` Ben Woodard
2006-10-04 7:07 ` David Miller
2006-10-04 8:56 ` Ingo Oeser
2006-10-04 9:08 ` David Miller
2006-10-04 17:17 ` Stephen Hemminger
2006-10-11 1:46 ` Ben Woodard
2006-10-11 1:59 ` YOSHIFUJI Hideaki / 吉藤英明
2006-10-11 2:53 ` David Miller [this message]
2006-10-11 2:54 ` David Miller
2006-10-11 14:01 ` Vlad Yasevich
2006-10-12 0:51 ` Ben Woodard
2006-10-12 1:06 ` YOSHIFUJI Hideaki / 吉藤英明
2006-10-12 15:49 ` Ben Woodard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010.195341.32721754.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=behlendorf1@llnl.gov \
--cc=mgrondona@llnl.gov \
--cc=netdev@vger.kernel.org \
--cc=woodard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).