From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Oeser Subject: Re: [patch 2/2] round_jiffies users Date: Tue, 10 Oct 2006 18:47:39 +0200 Message-ID: <200610101847.39604.netdev@axxeo.de> References: <1160496165.3000.308.camel@laptopd505.fenrus.org> <1160496210.3000.310.camel@laptopd505.fenrus.org> <1160496263.3000.312.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jgarzik@pobox.com, akpm@osdl.org, mingo@elte.hu Return-path: Received: from mail.axxeo.de ([82.100.226.146]:61394 "EHLO mail.axxeo.de") by vger.kernel.org with ESMTP id S1030199AbWJJQsB (ORCPT ); Tue, 10 Oct 2006 12:48:01 -0400 To: Arjan van de Ven In-Reply-To: <1160496263.3000.312.camel@laptopd505.fenrus.org> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Arjan, Arjan van de Ven wrote: > Index: linux-2.6.19-rc1-git6/mm/slab.c > =================================================================== > --- linux-2.6.19-rc1-git6.orig/mm/slab.c > +++ linux-2.6.19-rc1-git6/mm/slab.c > @@ -926,7 +926,7 @@ static void __devinit start_cpu_timer(in > if (keventd_up() && reap_work->func == NULL) { > init_reap_node(cpu); > INIT_WORK(reap_work, cache_reap, NULL); > - schedule_delayed_work_on(cpu, reap_work, HZ + 3 * cpu); > + schedule_delayed_work_on(cpu, reap_work, __round_jiffies_relative(HZ, cpu)); > } > } > Did you changed the behavior by intention? You seem to miss the factor "3" here. This hunk should read: --- linux-2.6.19-rc1-git6.orig/mm/slab.c +++ linux-2.6.19-rc1-git6/mm/slab.c @@ -926,7 +926,7 @@ static void __devinit start_cpu_timer(in if (keventd_up() && reap_work->func == NULL) { init_reap_node(cpu); INIT_WORK(reap_work, cache_reap, NULL); - schedule_delayed_work_on(cpu, reap_work, HZ + 3 * cpu); + schedule_delayed_work_on(cpu, reap_work, __round_jiffies_relative(HZ, 3 * cpu)); } } In case you apply it: Signed-off-by: Ingo Oese Regards Ingo Oeser