From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Buesch Subject: Re: [patch 2/3] d80211: remove poorly documented ieee80211_hw extra_hdr_room flag Date: Tue, 10 Oct 2006 23:04:05 +0200 Message-ID: <200610102304.05291.mb@bu3sch.de> References: <20061009170159.804032000@devicescape.com> <200610101200.12454.mb@bu3sch.de> <20061010134533.GB4518@devicescape.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "John W. Linville" , Jiri Benc Return-path: Received: from static-ip-62-75-166-246.inaddr.intergenia.de ([62.75.166.246]:59366 "EHLO bu3sch.de") by vger.kernel.org with ESMTP id S1030384AbWJJVEe (ORCPT ); Tue, 10 Oct 2006 17:04:34 -0400 To: David Kimdon In-Reply-To: <20061010134533.GB4518@devicescape.com> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tuesday 10 October 2006 15:45, David Kimdon wrote: > On Tue, Oct 10, 2006 at 12:00:12PM +0200, Michael Buesch wrote: > > On Monday 09 October 2006 19:03, David Kimdon wrote: > > > This flag is unused by all in tree drivers. Furthermore, the way that > > > it is documented is not consistent with the way it is actually used by > > > ieee80211.c. The original attempt appears to be something to do with > > > adding extra header room for low-level drivers which need to pad the > > > IEEE 802.11 header (example: Atheros). > > > > What about not removing it, but extending it. > > Sure, I would be happy with that. For Atheros it will be '2' to > ensure that we can properly align the packet in the tx path without > needing to realloc. Ok, nice. Do you want to do a patch or should I do? -- Greetings Michael.