From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [patch] Performance enhancement patches for SB1250 MAC Date: Thu, 12 Oct 2006 15:13:56 -0700 Message-ID: <20061012151356.4a3a4096@freekitty> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Return-path: Received: from smtp.osdl.org ([65.172.181.4]:49613 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751184AbWJLWN7 (ORCPT ); Thu, 12 Oct 2006 18:13:59 -0400 To: "Yang, Steve" In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 12 Oct 2006 14:54:33 -0700 "Yang, Steve" wrote: > FYI ... > > Regards, > Steve Yang > > -----Original Message----- > From: Yang, Steve > Sent: Monday, September 25, 2006 3:50 PM > To: 'linux-mips@linux-mips.org' > Cc: 'ralf@linux-mips.org'; 'Mark E Mason' > Subject: Performance enhancement patches for SB1250 MAC > > Hi, > > The attached are two network performance enhancement patches for SB1250 > MAC. The NAPI patch applies first. Followed by the "skb cache" patch. > They applied and builds cleanly on 2.6.18 kernel for the following > kernel option combinations: > > SBMAC_NAPI no yes yes > SKB_CACHE no no yes > > Regards, > Steve Yang > NAK on the SKB_CACHE it is idea that just ends up favoring your driver at the expense of the rest of the system. Also, there are resource/memory starvation issues and probably other races as well. I bet it makes your benchmark run faster, but it doesn't belong in normal kernel -- Stephen Hemminger