From: David Miller <davem@davemloft.net>
To: per.liden@ericsson.com
Cc: netdev@vger.kernel.org, jon.maloy@ericsson.com,
allan.stephens@windriver.com
Subject: Re: [PATCH 0/14] TIPC updates
Date: Mon, 16 Oct 2006 22:04:28 -0700 (PDT) [thread overview]
Message-ID: <20061016.220428.55725878.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0610131330350.30166@ulinpc219.uab.ericsson.se>
From: Per Liden <per.liden@ericsson.com>
Date: Fri, 13 Oct 2006 13:37:23 +0200 (CEST)
> This patch set includes a number TIPC fixes/cleanups. Please see each
> individual patch for further description.
>
> Please pull from:
>
> git://tipc.cslab.ericsson.net/pub/git/tipc.git
>
> (rebased on linux/kernel/git/davem/net-2.6.git)
I applied everything except patch 8/14, you really need to
add proper SKB queue locking to handle that race. I think
the "performance cost" of taking that lock is much overstated,
you should never have contention on that lock at all.
Secondly, I never pull from your trees because I still have
to make many fixups to your patches:
1) Please add a proper colon to your changeset header lines,
it should be "[TIPC]: ", not "[TIPC] ".
2) Please check for trailing whitespace added by your patches.
I've given you the command you can use in another email to
check this for yourselve before submission.
3) Please get full proper signed-off-by lines from patch submitters,
especially when the patch is more than a trivial 1 or 2 liner.
Thanks.
next prev parent reply other threads:[~2006-10-17 5:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 11:37 [PATCH 0/14] TIPC updates Per Liden
2006-10-13 11:37 ` [PATCH 1/14] [TIPC] Add missing unlock in port timeout code Per Liden
2006-10-17 4:39 ` David Miller
2006-10-13 11:37 ` [PATCH 2/14] [TIPC] Debug print buffer enhancements and fixes Per Liden
2006-10-17 4:43 ` David Miller
2006-10-13 11:37 ` [PATCH 3/14] [TIPC] Stream socket can now send > 66000 bytes at a time Per Liden
2006-10-17 4:44 ` David Miller
2006-10-13 11:37 ` [PATCH 4/14] [TIPC] Added duplicate node address detection capability Per Liden
2006-10-17 4:45 ` David Miller
2006-10-13 11:37 ` [PATCH 5/14] [TIPC] Optimize wakeup logic when socket has no waiting processes Per Liden
2006-10-17 4:48 ` David Miller
2006-10-13 11:37 ` [PATCH 6/14] [TIPC] Remove code bloat introduced by print buffer rework Per Liden
2006-10-17 4:49 ` David Miller
2006-10-13 11:37 ` [PATCH 7/14] [TIPC] Add support for Ethernet VLANs Per Liden
2006-10-17 4:50 ` David Miller
2006-10-13 11:37 ` [PATCH 8/14] [TIPC] Fix socket receive queue NULL pointer dereference on SMP systems Per Liden
2006-10-17 4:55 ` David Miller
2006-10-13 11:37 ` [PATCH 9/14] [TIPC] Name publication events now delivered in chronological order Per Liden
2006-10-13 23:13 ` Bill Fink
2006-10-16 8:50 ` Per Liden
2006-10-16 20:59 ` David Miller
2006-10-17 4:56 ` David Miller
2006-10-13 11:37 ` [PATCH 10/14] [TIPC] Fixed slow link reactivation when link tolerance is large Per Liden
2006-10-17 4:57 ` David Miller
2006-10-13 11:37 ` [PATCH 11/14] [TIPC] Can now list multicast link on an isolated network node Per Liden
2006-10-17 4:58 ` David Miller
2006-10-13 11:37 ` [PATCH 12/14] [TIPC] Added subscription cancellation capability Per Liden
2006-10-17 5:00 ` David Miller
2006-10-13 11:37 ` [PATCH 13/14] [TIPC] Unrecognized configuration command now returns error message Per Liden
2006-10-17 5:01 ` David Miller
2006-10-13 11:37 ` [PATCH 14/14] [TIPC] Updated TIPC version number to 1.6.2 Per Liden
2006-10-17 5:01 ` David Miller
2006-10-17 5:04 ` David Miller [this message]
2006-10-18 8:24 ` [PATCH 0/14] TIPC updates Per Liden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061016.220428.55725878.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allan.stephens@windriver.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=per.liden@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).