From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH] NET : Suspicious locking in reqsk_queue_hash_req()
Date: Mon, 16 Oct 2006 11:00:22 +0200 [thread overview]
Message-ID: <200610161100.22549.dada1@cosmosbay.com> (raw)
In-Reply-To: <200610111511.19028.dada1@cosmosbay.com>
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
Hi David
While browsing include/net/request_sock.h I found this suspicious locking
protecting the SYN table hash table. I think this patch is necessary.
Thank you
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
[-- Attachment #2: reqsk_queue_hash_req.patch --]
[-- Type: text/plain, Size: 454 bytes --]
--- linux-2.6.18/include/net/request_sock.h.orig 2006-10-16 10:53:11.000000000 +0200
+++ linux-2.6.18-ed/include/net/request_sock.h 2006-10-16 10:53:24.000000000 +0200
@@ -251,9 +251,9 @@
req->expires = jiffies + timeout;
req->retrans = 0;
req->sk = NULL;
- req->dl_next = lopt->syn_table[hash];
write_lock(&queue->syn_wait_lock);
+ req->dl_next = lopt->syn_table[hash];
lopt->syn_table[hash] = req;
write_unlock(&queue->syn_wait_lock);
}
next prev parent reply other threads:[~2006-10-16 9:00 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 17:47 Dropping NETIF_F_SG since no checksum feature Michael S. Tsirkin
2006-10-09 16:50 ` Stephen Hemminger
2006-10-10 14:43 ` Michael S. Tsirkin
2006-10-10 17:43 ` Stephen Hemminger
2006-10-11 0:13 ` Michael S. Tsirkin
2006-10-11 0:15 ` Roland Dreier
2006-10-11 0:26 ` Michael S. Tsirkin
2006-10-11 3:33 ` Roland Dreier
2006-10-11 3:36 ` David Miller
2006-10-11 3:42 ` Roland Dreier
2006-10-11 3:45 ` David Miller
2006-10-11 3:49 ` Roland Dreier
2006-10-11 3:50 ` David Miller
2006-10-11 2:15 ` David Miller
2006-10-11 9:05 ` Michael S. Tsirkin
2006-10-11 9:09 ` Steven Whitehouse
2006-10-11 15:01 ` Michael S. Tsirkin
2006-10-11 20:11 ` Steven Whitehouse
2006-10-11 20:52 ` Michael S. Tsirkin
2006-10-11 20:57 ` Stephen Hemminger
2006-10-11 21:23 ` Michael S. Tsirkin
2006-10-11 21:29 ` Stephen Hemminger
2006-10-11 21:42 ` Michael S. Tsirkin
2006-10-11 21:41 ` David Miller
2006-10-12 19:12 ` Michael S. Tsirkin
2006-10-13 4:22 ` David Miller
2006-10-13 6:17 ` Michael S. Tsirkin
2006-10-11 20:52 ` David Miller
2006-10-11 21:11 ` Michael S. Tsirkin
2006-10-11 9:20 ` David Miller
2006-10-11 9:46 ` Michael S. Tsirkin
2006-10-11 18:21 ` [openib-general] " Michael Krause
2006-10-11 13:11 ` [RFC] Question about potential problem in net/ipv4/route.c Eric Dumazet
2006-10-12 5:05 ` David Miller
2006-10-12 5:31 ` Patrick McHardy
2006-10-12 5:54 ` David Miller
2006-10-12 5:48 ` Eric Dumazet
2006-10-12 6:02 ` David Miller
2006-10-12 6:10 ` Patrick McHardy
2006-10-12 6:25 ` David Miller
2006-10-12 6:35 ` Eric Dumazet
2006-10-12 7:48 ` David Miller
2006-10-16 9:00 ` Eric Dumazet [this message]
2006-10-16 9:07 ` [PATCH] NET : Suspicious locking in reqsk_queue_hash_req() Eric Dumazet
2006-10-16 16:16 ` Arnaldo Carvalho de Melo
2006-10-16 16:56 ` Eric Dumazet
2006-10-16 17:39 ` Eric Dumazet
2006-10-16 20:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610161100.22549.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).