[take1 0/5] d80211 patches

[take1 0/5] d80211 patches

[David Kimdon]

Continue d80211 bitfield removal.  In general, compilers have
difficulty generating efficient code for bitfields.  This patchset
removes all bitfields from include/net/d80211.h.

I converted the 1 bit bitfields into a bit in a u32/u16 or u8 flags
structure member.  Larger bitfields I converted into their
u8/u16/whatever equivalent.

This should be a no-op from a functionality standpoint.

All tests using gcc 4.1.2.

The size of structures where bitfields were removed is identical
patched and unpatched.  All object text size is either slightly
smaller after the patch, or unchanged (bss and data are all
unchanged).  With all d80211 drivers compiled in the patched vmlinux
is 752 bytes smaller.

Changes from take0:

Update the patches to apply on top of the following patches:

d80211: remove unused Super AG definitions, purge comment
    (http://marc.theaimsgroup.com/?l=linux-netdev&m=116102409931269&w=2)
d80211: remove initialization of unused xr structure members
    (http://marc.theaimsgroup.com/?l=linux-netdev&m=116076811809305&w=4)
d80211: remove unused xr structure members, interface, etc.
    (http://marc.theaimsgroup.com/?l=linux-netdev&m=115989929600617&w=4)

For key_conf_bitfields.patch change the new flags member to u8 from u32.

For tx_control_bitfields.patch move the rts_cts_duration and retry_limit members
in ieee80211_tx_control to allow for smaller structure size and change the
flags member from u32 to u16. 

For tx_status_bitfields.patch, in
drivers/net/wireless/d80211/bcm43xx/bcm43xx_dma.c and
drivers/net/wireless/d80211/bcm43xx/bcm43xx_pio.c note that
ieee80211_tx_status is already zero'd, so the ack bit only needs to be
set, not cleared.

--

Re: [take1 0/5] d80211 patches

[Jiri Benc]

On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote:
> Continue d80211 bitfield removal.  In general, compilers have
> difficulty generating efficient code for bitfields.  This patchset
> removes all bitfields from include/net/d80211.h.

Thanks for the patches! At first I intended to ask you to split d80211
and drivers parts of the patches, but your way is better I think - it
doesn't break git-bisect.

John, if you agree with these patches, could you apply them after you
pull from my tree?

Thanks,

 Jiri

-- 
Jiri Benc
SUSE Labs

Re: [take1 0/5] d80211 patches

[David Kimdon]

On Wed, Oct 18, 2006 at 06:01:31PM +0200, Jiri Benc wrote:
> On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote:
> > Continue d80211 bitfield removal.  In general, compilers have
> > difficulty generating efficient code for bitfields.  This patchset
> > removes all bitfields from include/net/d80211.h.
> 
> Thanks for the patches! At first I intended to ask you to split d80211
> and drivers parts of the patches, but your way is better I think - it
> doesn't break git-bisect.
> 
> John, if you agree with these patches, could you apply them after you
> pull from my tree?

hold that thought, I missed updating rt73usb.c and rt2500usb.c.  New
patchset on its way.



> 
> Thanks,
> 
>  Jiri
> 
> -- 
> Jiri Benc
> SUSE Labs

Re: [take1 0/5] d80211 patches

[Ivo van Doorn]

On Wednesday 18 October 2006 19:20, David Kimdon wrote:
> On Wed, Oct 18, 2006 at 06:01:31PM +0200, Jiri Benc wrote:
> > On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote:
> > > Continue d80211 bitfield removal.  In general, compilers have
> > > difficulty generating efficient code for bitfields.  This patchset
> > > removes all bitfields from include/net/d80211.h.
> > 
> > Thanks for the patches! At first I intended to ask you to split d80211
> > and drivers parts of the patches, but your way is better I think - it
> > doesn't break git-bisect.
> > 
> > John, if you agree with these patches, could you apply them after you
> > pull from my tree?
> 
> hold that thought, I missed updating rt73usb.c and rt2500usb.c.  New
> patchset on its way.

Hi,

That patch was send 2 hours ago by me to this list. :)
"[PATCH] rt2x00: Remove xr_end references"
That patch only fixed rt2500usb and rt73usb, so it can be applied safely
after your patch to fix the rt2x00 PCI drivers. 

Ivo

Re: [take1 0/5] d80211 patches

[David Kimdon]

On Wed, Oct 18, 2006 at 07:23:14PM +0200, Ivo van Doorn wrote:
> On Wednesday 18 October 2006 19:20, David Kimdon wrote:
> > On Wed, Oct 18, 2006 at 06:01:31PM +0200, Jiri Benc wrote:
> > > On Tue, 17 Oct 2006 10:17:13 -0700, David Kimdon wrote:
> > > > Continue d80211 bitfield removal.  In general, compilers have
> > > > difficulty generating efficient code for bitfields.  This patchset
> > > > removes all bitfields from include/net/d80211.h.
> > > 
> > > Thanks for the patches! At first I intended to ask you to split d80211
> > > and drivers parts of the patches, but your way is better I think - it
> > > doesn't break git-bisect.
> > > 
> > > John, if you agree with these patches, could you apply them after you
> > > pull from my tree?
> > 
> > hold that thought, I missed updating rt73usb.c and rt2500usb.c.  New
> > patchset on its way.
> 
> Hi,
> 
> That patch was send 2 hours ago by me to this list. :)
> "[PATCH] rt2x00: Remove xr_end references"
> That patch only fixed rt2500usb and rt73usb, so it can be applied safely
> after your patch to fix the rt2x00 PCI drivers. 

Sorry, to be clear, I am talking about the bitfield removal from
d80211.h patches.  Actually, your patch to remove the xr references
from the usb drivers is what made me notice I had forgotten them from
the bitfield removal patches.

hmm, I have a bad subject to the first mail in my post, my posting
script set the initial 0/5 message subject as 'd80211 patches', should
probably be a bit more specific :-)

-David