From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH] [NET] inet_peer : group together avl_left, avl_right, v4daddr to speedup lookups on some CPUS
Date: Wed, 18 Oct 2006 09:38:38 +0200 [thread overview]
Message-ID: <200610180938.39175.dada1@cosmosbay.com> (raw)
In-Reply-To: <200610171458.37636.dada1@cosmosbay.com>
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
Hi David
Lot of routers still use CPUS with 32 bytes cache lines. (Intel PIII)
It make sense to make sure fields used at lookup time are in the same cache
line, to reduce cache footprint and speedup lookups.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
[-- Attachment #2: inetpeer_speedup.patch --]
[-- Type: text/plain, Size: 773 bytes --]
--- linux/include/net/inetpeer.h 2006-10-18 09:30:12.000000000 +0200
+++ linux-ed/include/net/inetpeer.h 2006-10-18 09:32:17.000000000 +0200
@@ -17,14 +17,15 @@
struct inet_peer
{
+ /* group together avl_left,avl_right,v4daddr to speedup lookups */
struct inet_peer *avl_left, *avl_right;
+ __u32 v4daddr; /* peer's address */
+ __u16 avl_height;
+ __u16 ip_id_count; /* IP ID for the next packet */
struct inet_peer *unused_next, **unused_prevp;
__u32 dtime; /* the time of last use of not
* referenced entries */
atomic_t refcnt;
- __u32 v4daddr; /* peer's address */
- __u16 avl_height;
- __u16 ip_id_count; /* IP ID for the next packet */
atomic_t rid; /* Frag reception counter */
__u32 tcp_ts;
unsigned long tcp_ts_stamp;
next prev parent reply other threads:[~2006-10-18 7:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 0:53 [PATCH] Bound TSO defer time (resend) John Heffner
2006-10-17 3:20 ` Stephen Hemminger
2006-10-17 4:18 ` John Heffner
2006-10-17 5:35 ` David Miller
2006-10-17 12:22 ` John Heffner
2006-10-19 3:39 ` David Miller
2006-10-17 12:58 ` [PATCH] [NET] Size listen hash tables using backlog hint Eric Dumazet Hi
2006-10-18 7:38 ` Eric Dumazet [this message]
2006-10-18 16:35 ` [PATCH] [NET] reduce per cpu ram used for loopback stats Eric Dumazet
2006-10-18 17:00 ` [PATCH, resent] " Eric Dumazet
2006-10-19 3:53 ` David Miller
2006-10-19 3:53 ` [PATCH] " David Miller
2006-10-19 3:44 ` [PATCH] [NET] inet_peer : group together avl_left, avl_right, v4daddr to speedup lookups on some CPUS David Miller
2006-10-19 10:57 ` Eric Dumazet
2006-10-19 15:45 ` [PATCH] [NET] One NET_INC_STATS() could be NET_INC_STATS_BH in tcp_v4_err() Eric Dumazet
2006-10-20 7:22 ` David Miller
2006-10-20 14:21 ` Arnaldo Carvalho de Melo
2006-10-20 7:28 ` [PATCH] [NET] inet_peer : group together avl_left, avl_right, v4daddr to speedup lookups on some CPUS David Miller
2006-10-19 3:31 ` [PATCH] [NET] Size listen hash tables using backlog hint David Miller
2006-10-19 4:54 ` Stephen Hemminger
2006-10-19 5:08 ` David Miller
2006-10-19 5:12 ` Eric Dumazet
2006-10-19 6:12 ` David Miller
2006-10-19 6:34 ` Eric Dumazet
2006-10-19 6:57 ` David Miller
2006-10-19 8:29 ` Eric Dumazet
2006-10-19 8:41 ` David Miller
2006-10-19 9:11 ` Eric Dumazet
2006-10-19 9:27 ` Eric Dumazet
2006-10-20 7:27 ` David Miller
2006-10-18 15:37 ` [PATCH] Bound TSO defer time (resend) Andi Kleen
2006-10-18 16:40 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610180938.39175.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).