From: Jiri Benc <jbenc@suse.cz>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: netdev@vger.kernel.org, Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH] d80211: ieee80211_hw handlers should be allowed to sleep
Date: Wed, 18 Oct 2006 15:06:09 +0200 [thread overview]
Message-ID: <20061018150609.6542af30@griffin.suse.cz> (raw)
In-Reply-To: <200610071123.15561.IvDoorn@gmail.com>
On Sat, 7 Oct 2006 11:23:15 +0200, Ivo van Doorn wrote:
> --- a/net/d80211/ieee80211.c
> +++ b/net/d80211/ieee80211.c
> @@ -2075,15 +2075,15 @@ void ieee80211_if_shutdown(struct net_de
> case IEEE80211_IF_TYPE_STA:
> case IEEE80211_IF_TYPE_IBSS:
> sdata->u.sta.state = IEEE80211_DISABLED;
> - del_timer_sync(&sdata->u.sta.timer);
> + cancel_delayed_work(&sdata->u.sta.work);
> if (local->scan_work.data == sdata->dev) {
> local->sta_scanning = 0;
> cancel_delayed_work(&local->scan_work);
> - flush_scheduled_work();
> /* see comment in ieee80211_unregister_hw to
> * understand why this works */
> local->scan_work.data = NULL;
> }
> + flush_scheduled_work();
This is racy. local->scan_work.data can be set to NULL only after
flush_scheduled_work().
Other than that, the patch looks good to me.
Thanks,
Jiri
--
Jiri Benc
SUSE Labs
next prev parent reply other threads:[~2006-10-18 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-07 9:23 [PATCH] d80211: ieee80211_hw handlers should be allowed to sleep Ivo van Doorn
2006-10-18 13:06 ` Jiri Benc [this message]
2006-10-18 17:27 ` Ivo van Doorn
2006-10-18 18:10 ` Jan Kiszka
2006-10-19 16:01 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061018150609.6542af30@griffin.suse.cz \
--to=jbenc@suse.cz \
--cc=ivdoorn@gmail.com \
--cc=jan.kiszka@web.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).