* [patch] d80211: remove initialization of unused xr structure members
@ 2006-10-13 19:34 David Kimdon
2006-10-18 15:55 ` Jiri Benc
0 siblings, 1 reply; 3+ messages in thread
From: David Kimdon @ 2006-10-13 19:34 UTC (permalink / raw)
To: netdev; +Cc: John W. Linville, Jiri Benc, David Kimdon
[-- Attachment #1: drivers-xr-removal.patch --]
[-- Type: text/plain, Size: 1915 bytes --]
The structure member xr_end was removed from d80211.h.
Signed-off-by: David Kimdon <david.kimdon@devicescape.com>
Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2400pci.c
===================================================================
--- wireless-dev.orig/drivers/net/wireless/d80211/rt2x00/rt2400pci.c
+++ wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2400pci.c
@@ -2704,11 +2704,6 @@ static int rt2400pci_init_hw_modes(struc
rt2400pci_init_hw_channels(rt2x00dev, hw->modes->channels);
rt2400pci_init_hw_rates(rt2x00dev, hw->modes->rates);
- /*
- * xr_end is only used on Atheros cards.
- */
- hw->modes->xr_end = 0;
-
return ieee80211_update_hw(net_dev, hw);
exit_free_channels:
Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2500pci.c
===================================================================
--- wireless-dev.orig/drivers/net/wireless/d80211/rt2x00/rt2500pci.c
+++ wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2500pci.c
@@ -2989,11 +2989,6 @@ static int rt2500pci_init_hw_modes(struc
rt2500pci_init_hw_channels(rt2x00dev, hw->modes[0].channels);
rt2500pci_init_hw_rates(rt2x00dev, hw->modes[0].rates);
- /*
- * xr_end is only used on Atheros cards.
- */
- hw->modes->xr_end = 0;
-
return ieee80211_update_hw(net_dev, hw);
exit_free_channels:
Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt61pci.c
===================================================================
--- wireless-dev.orig/drivers/net/wireless/d80211/rt2x00/rt61pci.c
+++ wireless-dev/drivers/net/wireless/d80211/rt2x00/rt61pci.c
@@ -3501,11 +3501,6 @@ static int rt61pci_init_hw_modes(struct
rt61pci_init_hw_channels(rt2x00dev, hw->modes[0].channels);
rt61pci_init_hw_rates(rt2x00dev, hw->modes[0].rates);
- /*
- * xr_end is only used on Atheros cards.
- */
- hw->modes->xr_end = 0;
-
return ieee80211_update_hw(net_dev, hw);
exit_free_channels:
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] d80211: remove initialization of unused xr structure members
2006-10-13 19:34 [patch] d80211: remove initialization of unused xr structure members David Kimdon
@ 2006-10-18 15:55 ` Jiri Benc
2006-10-18 16:03 ` Ivo van Doorn
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Benc @ 2006-10-18 15:55 UTC (permalink / raw)
To: John W. Linville; +Cc: David Kimdon, netdev, Ivo van Doorn
On Fri, 13 Oct 2006 12:34:57 -0700, David Kimdon wrote:
> The structure member xr_end was removed from d80211.h.
John, please apply this after you pull from my tree (perhaps with a
rt2x00 prefix in the subject instead of d80211?).
Thanks,
Jiri
--
Jiri Benc
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] d80211: remove initialization of unused xr structure members
2006-10-18 15:55 ` Jiri Benc
@ 2006-10-18 16:03 ` Ivo van Doorn
0 siblings, 0 replies; 3+ messages in thread
From: Ivo van Doorn @ 2006-10-18 16:03 UTC (permalink / raw)
To: Jiri Benc; +Cc: John W. Linville, David Kimdon, netdev
Hi,
> > The structure member xr_end was removed from d80211.h.
>
> John, please apply this after you pull from my tree (perhaps with a
> rt2x00 prefix in the subject instead of d80211?).
The patch itself looked good, but it doesn't fix rt2500usb and rt73usb,
I will send a patch to fix the rt2x00 USB drivers shortly.
Ivo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-18 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-13 19:34 [patch] d80211: remove initialization of unused xr structure members David Kimdon
2006-10-18 15:55 ` Jiri Benc
2006-10-18 16:03 ` Ivo van Doorn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).