From: Chris Leech <christopher.leech@intel.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
akpm@osdl.org, jeff@garzik.org
Subject: [PATCH 4/7] I/OAT: Remove the use of writeq from the ioatdma driver
Date: Wed, 18 Oct 2006 16:46:55 -0700 [thread overview]
Message-ID: <20061018234655.26671.3357.stgit@gitlost.site> (raw)
In-Reply-To: <20061018234417.26671.56773.stgit@gitlost.site>
There's only one now anyway, and it's not in a performance path,
so make it behave the same on 32-bit and 64-bit CPUs.
Signed-off-by: Chris Leech <christopher.leech@intel.com>
---
drivers/dma/ioatdma.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/dma/ioatdma.c b/drivers/dma/ioatdma.c
index ceb03ee..2800c19 100644
--- a/drivers/dma/ioatdma.c
+++ b/drivers/dma/ioatdma.c
@@ -608,13 +608,11 @@ static void ioat_start_null_desc(struct
list_add_tail(&desc->node, &ioat_chan->used_desc);
spin_unlock_bh(&ioat_chan->desc_lock);
-#if (BITS_PER_LONG == 64)
- writeq(desc->phys, ioat_chan->reg_base + IOAT_CHAINADDR_OFFSET);
-#else
- writel((u32) desc->phys,
+ writel(((u64) desc->phys) & 0x00000000FFFFFFFF,
ioat_chan->reg_base + IOAT_CHAINADDR_OFFSET_LOW);
- writel(0, ioat_chan->reg_base + IOAT_CHAINADDR_OFFSET_HIGH);
-#endif
+ writel(((u64) desc->phys) >> 32,
+ ioat_chan->reg_base + IOAT_CHAINADDR_OFFSET_HIGH);
+
writeb(IOAT_CHANCMD_START, ioat_chan->reg_base + IOAT_CHANCMD_OFFSET);
}
next prev parent reply other threads:[~2006-10-18 23:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 23:44 [PATCH 0/7] drivers/dma & I/OAT fixes Chris Leech
2006-10-18 23:46 ` [PATCH 1/7] I/OAT: Push pending transactions to hardware more frequently Chris Leech
2006-10-18 23:46 ` [PATCH 2/7] drivers/dma: handle sysfs errors Chris Leech
2006-10-18 23:46 ` [PATCH 3/7] I/OAT: Remove the wrappers around read(bwl)/write(bwl) in ioatdma Chris Leech
2006-10-18 23:46 ` Chris Leech [this message]
2006-10-18 23:46 ` [PATCH 5/7] I/OAT: Add documentation for the tcp_dma_copybreak sysctl Chris Leech
2006-10-18 23:46 ` [PATCH 6/7] I/OAT: Add entries to MAINTAINERS for the DMA memcpy subsystem and ioatdma Chris Leech
2006-10-18 23:47 ` [PATCH 7/7] I/OAT: Only offload copies for TCP when there will be a context switch Chris Leech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061018234655.26671.3357.stgit@gitlost.site \
--to=christopher.leech@intel.com \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).