From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jeff Garzik <jgarzik@pobox.com>,
Paul Mackerras <paulus@samba.org>,
Mirko Lindner <mlindner@syskonnect.de>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH 4/6] net: use bitrev8
Date: Fri, 20 Oct 2006 11:50:45 +0900 [thread overview]
Message-ID: <20061020025045.GB6344@localhost> (raw)
In-Reply-To: <20061019133951.1d463173.akpm@osdl.org>
On Thu, Oct 19, 2006 at 01:39:51PM -0700, Andrew Morton wrote:
> A bunch of drivers.
>
> > ===================================================================
> > --- work-fault-inject.orig/drivers/net/Kconfig
> > +++ work-fault-inject/drivers/net/Kconfig
> > @@ -2500,6 +2500,7 @@ config DEFXX
> > config SKFP
> > tristate "SysKonnect FDDI PCI support"
> > depends on FDDI && PCI
> > + select BITREVERSE
> > ---help---
> > Say Y here if you have a SysKonnect FDDI PCI adapter.
> > The following adapters are supported by this driver:
>
> But only one of them selects the library.
Other drivers already select CRC32 and CRC32 selects BITREVERSE.
> But select is problematic and I do wonder whether it'd be simpler to just
> link the thing into vmlinux.
OK. I'll try.
next prev parent reply other threads:[~2006-10-20 2:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 16:46 [PATCH 4/6] net: use bitrev8 Akinobu Mita
2006-10-19 20:39 ` Andrew Morton
2006-10-20 2:50 ` Akinobu Mita [this message]
2006-10-20 9:54 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061020025045.GB6344@localhost \
--to=akinobu.mita@gmail.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@syskonnect.de \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).