* revert mv643xx change from ubuntu tree
@ 2006-10-19 12:18 Olaf Hering
2006-10-20 4:35 ` Ben Collins
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2006-10-19 12:18 UTC (permalink / raw)
To: linux-kernel, netdev, Linus Torvalds, Jeff Garzik
Somehow the Ubuntu guys managed to sneak this compile error into the
tree:
commit ce9e3d9953c8cb67001719b5516da2928e956be4
[mv643xx] Add pci device table for auto module loading.
drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type
drivers/net/mv643xx_eth.c:1561: warning: implicit declaration of function ‘PCI_DEVICE’
drivers/net/mv643xx_eth.c:1561: error: ‘PCI_VENDOR_ID_MARVELL’ undeclared here (not in a function)
drivers/net/mv643xx_eth.c:1561: error: ‘PCI_DEVICE_ID_MARVELL_MV64360’ undeclared here (not in a function)
This change is also wrong, the autoloading works perfect with 2.6.18,
no need to add random PCI ids.
http://ozlabs.org/pipermail/linuxppc-dev/2006-October/026544.html
Please revert this change and route changes via jgarzik etc...
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: revert mv643xx change from ubuntu tree
2006-10-19 12:18 revert mv643xx change from ubuntu tree Olaf Hering
@ 2006-10-20 4:35 ` Ben Collins
2006-10-20 5:38 ` Olaf Hering
0 siblings, 1 reply; 3+ messages in thread
From: Ben Collins @ 2006-10-20 4:35 UTC (permalink / raw)
To: Olaf Hering; +Cc: linux-kernel, netdev, Linus Torvalds, Jeff Garzik
On Thu, 2006-10-19 at 14:18 +0200, Olaf Hering wrote:
> Somehow the Ubuntu guys managed to sneak this compile error into the
> tree:
>
> commit ce9e3d9953c8cb67001719b5516da2928e956be4
>
> [mv643xx] Add pci device table for auto module loading.
>
> drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type
> drivers/net/mv643xx_eth.c:1561: warning: implicit declaration of function ‘PCI_DEVICE’
> drivers/net/mv643xx_eth.c:1561: error: ‘PCI_VENDOR_ID_MARVELL’ undeclared here (not in a function)
> drivers/net/mv643xx_eth.c:1561: error: ‘PCI_DEVICE_ID_MARVELL_MV64360’ undeclared here (not in a function)
Correct, I missed the include for linux/pci.h.
This patch has been trailing our tree since 2.6.12. Could you help me to
understand what in this driver will cause it to be autoloaded by udev
when compiled as a module?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: revert mv643xx change from ubuntu tree
2006-10-20 4:35 ` Ben Collins
@ 2006-10-20 5:38 ` Olaf Hering
0 siblings, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2006-10-20 5:38 UTC (permalink / raw)
To: Ben Collins; +Cc: linux-kernel, netdev, Linus Torvalds, Jeff Garzik
On Fri, Oct 20, Ben Collins wrote:
> On Thu, 2006-10-19 at 14:18 +0200, Olaf Hering wrote:
> > Somehow the Ubuntu guys managed to sneak this compile error into the
> > tree:
> >
> > commit ce9e3d9953c8cb67001719b5516da2928e956be4
> >
> > [mv643xx] Add pci device table for auto module loading.
> >
> > drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type
> > drivers/net/mv643xx_eth.c:1561: warning: implicit declaration of function ‘PCI_DEVICE’
> > drivers/net/mv643xx_eth.c:1561: error: ‘PCI_VENDOR_ID_MARVELL’ undeclared here (not in a function)
> > drivers/net/mv643xx_eth.c:1561: error: ‘PCI_DEVICE_ID_MARVELL_MV64360’ undeclared here (not in a function)
>
> Correct, I missed the include for linux/pci.h.
>
> This patch has been trailing our tree since 2.6.12. Could you help me to
> understand what in this driver will cause it to be autoloaded by udev
> when compiled as a module?
See commit ce9e3d9953c8cb67001719b5516da2928e956be4, platform devices
have now a modalias entry in sysfs. The network card is not a PCI
device.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-20 5:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-19 12:18 revert mv643xx change from ubuntu tree Olaf Hering
2006-10-20 4:35 ` Ben Collins
2006-10-20 5:38 ` Olaf Hering
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).