From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 2/3] netpoll: rework skb transmit queue Date: Fri, 20 Oct 2006 08:18:57 -0700 Message-ID: <20061020081857.743b5eb7@localhost.localdomain> References: <20061019171541.062261760@osdl.org> <20061019171814.281988608@osdl.org> <20061020.001530.35664340.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from smtp.osdl.org ([65.172.181.4]:30694 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751084AbWJTPTG (ORCPT ); Fri, 20 Oct 2006 11:19:06 -0400 To: David Miller In-Reply-To: <20061020.001530.35664340.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, 20 Oct 2006 00:15:30 -0700 (PDT) David Miller wrote: > From: Stephen Hemminger > Date: Thu, 19 Oct 2006 10:15:43 -0700 > > > The original skb management for netpoll was a mess, it had two queue paths > > and a callback. This changes it to have a per-instance transmit queue > > and use a tasklet rather than a work queue for the congested case. > > > > Signed-off-by: Stephen Hemminger > > I think you mis-diffed this one: > > - WARN_ON(skb->protocol == 0); > > That line doesn't exist in my copy of net/core/netpoll.c > even with your first patch applied. > > Also, you forgot to remove the ->drop callback pointer > from struct netpoll, which you should do if it really > isn't used any more. > > I think you might run into problems there, as I believe the netdump > stuff does make non-trivial use of the ->drop callback. Indeed, it > uses the ->dump callback for invoking a special > netpoll_start_netdump() function. I'm pretty sure ->dump was created > specifically to accomodate netdump. > Netdump is not in the tree, so I can't fix it. Also netdump is pretty much superseded by kdump. > So this is something else which will need to be worked out before we > can apply this patch.