netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: Steven Whitehouse <steve@chygwyn.com>,
	David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH] [NET] reduce sizeof(struct flowi) by 20 bytes
Date: Fri, 20 Oct 2006 15:55:33 +0200	[thread overview]
Message-ID: <200610201555.33736.dada1@cosmosbay.com> (raw)
In-Reply-To: <20061018124202.GA31981@fogou.chygwyn.com>

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

Hi all

As suggested by David, just kill off some unused fields in dnports to reduce 
sizef(struct flowi). If they come back, they should be moved to nl_u.dn_u in 
order not to enlarge again struct flowi

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

[-- Attachment #2: shrink_flowi.patch --]
[-- Type: text/plain, Size: 1068 bytes --]

diff --git a/include/net/dn.h b/include/net/dn.h
index 465b783..c39385b 100644
--- a/include/net/dn.h
+++ b/include/net/dn.h
@@ -199,11 +199,13 @@ static inline void dn_sk_ports_copy(stru
 {
 	fl->uli_u.dnports.sport = scp->addrloc;
 	fl->uli_u.dnports.dport = scp->addrrem;
+#if 0 /* not yet used */
 	fl->uli_u.dnports.objnum = scp->addr.sdn_objnum;
 	if (fl->uli_u.dnports.objnum == 0) {
 		fl->uli_u.dnports.objnamel = (__u8)dn_ntohs(scp->addr.sdn_objnamel);
 		memcpy(fl->uli_u.dnports.objname, scp->addr.sdn_objname, 16);
 	}
+#endif
 }
 
 extern unsigned dn_mss_from_pmtu(struct net_device *dev, int mtu);
diff --git a/include/net/flow.h b/include/net/flow.h
index 3b44d72..bdc0e49 100644
--- a/include/net/flow.h
+++ b/include/net/flow.h
@@ -68,9 +68,11 @@ #define FLOWI_FLAG_MULTIPATHOLDROUTE 0x0
 		struct {
 			__le16	sport;
 			__le16	dport;
+#if 0 /* not yet used, should move to nl_u.dn_u */
 			__u8	objnum;
 			__u8	objnamel; /* Not 16 bits since max val is 16 */
 			__u8	objname[16]; /* Not zero terminated */
+#endif
 		} dnports;
 
 		__be32		spi;

  parent reply	other threads:[~2006-10-20 13:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20051217071029.GY23384@wotan.suse.de>
     [not found] ` <20051216.231517.68922847.davem@davemloft.net>
     [not found]   ` <43A3EE8A.5020907@cosmosbay.com>
     [not found]     ` <43CCBF3D.2070900@cosmosbay.com>
     [not found]       ` <4415A4C1.1030906@cosmosbay.com>
2006-10-12 20:14         ` [PATCH] [NET] reduce sizeof(struct inet_peer), cleanup, change in peer_check_expire() Eric Dumazet
2006-10-12 22:15           ` David Miller
2006-10-13  3:56             ` Eric Dumazet
2006-10-13  4:18               ` David Miller
2006-10-13  4:24                 ` Eric Dumazet
2006-10-18  5:08           ` [PATCH] [NET] reduce sizeof(struct flow) Eric Dumazet
2006-10-18  5:17             ` YOSHIFUJI Hideaki / 吉藤英明
2006-10-18  5:30               ` Eric Dumazet
2006-10-18  5:27             ` David Miller
2006-10-18  5:42               ` Eric Dumazet
2006-10-18  6:53                 ` David Miller
2006-10-18  8:20                   ` Steven Whitehouse
2006-10-18  8:55                     ` Eric Dumazet
2006-10-18 12:42                       ` Steven Whitehouse
2006-10-18 13:32                         ` Eric Dumazet
2006-10-19  3:50                           ` David Miller
2006-10-19  5:13                             ` Eric Dumazet
2006-10-20 13:55                         ` Eric Dumazet [this message]
2006-10-22  3:25                           ` [PATCH] [NET] reduce sizeof(struct flowi) by 20 bytes David Miller
2006-10-18 11:33               ` [PATCH] [NET] reduce sizeof(struct flow) Ingo Oeser
2006-10-20  7:18             ` [PATCH] [NET] can use __get_cpu_var() instead of per_cpu() in loopback driver Eric Dumazet
2006-10-20  7:32               ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200610201555.33736.dada1@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=steve@chygwyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).