From: David Miller <davem@davemloft.net>
To: randy.dunlap@oracle.com
Cc: netdev@vger.kernel.org, chas@cmf.nrl.navy.mil
Subject: Re: [PATCH] atm: fix horizon init section usage
Date: Sun, 22 Oct 2006 21:39:55 -0700 (PDT) [thread overview]
Message-ID: <20061022.213955.85411282.davem@davemloft.net> (raw)
In-Reply-To: <453C45D4.6080904@oracle.com>
From: "Randy.Dunlap" <randy.dunlap@oracle.com>
Date: Sun, 22 Oct 2006 21:32:20 -0700
> David Miller wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > Date: Sun, 22 Oct 2006 19:13:09 -0700
> >
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> hrz_init() is called from the probe function, which is __devinit
> >> and could be called after init.
> >>
> >> WARNING: drivers/atm/horizon.o - Section mismatch: reference to .init.text:.hrz_init from .text between '.hrz_probe' (at offset 0x4054) and '.hrz_remove_one'
> >>
> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > It is only called from hrz_init() and thus shouldn't it be
> > thus marked __devinit as well? That seems to be the right
> > way to fix this one.
>
> Oops, I agree. Want me to send another patch?
No need, I'll take care of it, thanks Randy.
next prev parent reply other threads:[~2006-10-23 4:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 2:13 [PATCH] atm: fix horizon init section usage Randy Dunlap
2006-10-23 3:39 ` David Miller
2006-10-23 4:32 ` Randy.Dunlap
2006-10-23 4:39 ` David Miller [this message]
2006-10-23 16:31 ` Randy.Dunlap
2006-10-24 23:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061022.213955.85411282.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).