From: Gavin McCullagh <gavin.mccullagh@nuim.ie>
To: NetDev <netdev@vger.kernel.org>
Cc: Douglas Leith <doug.leith@nuim.ie>, Baruch Even <baruch@ev-en.org>
Subject: [PATCH] fix integer overflow in H-TCP congestion control
Date: Tue, 24 Oct 2006 15:17:39 +0100 [thread overview]
Message-ID: <20061024141739.GB18364@nuim.ie> (raw)
When using H-TCP with a single flow on a 500Mbit connection (or less
actually), alpha can exceed 65000, so alpha needs to be a u32.
Signed-off-by: Gavin McCullagh <gavin.mccullagh@nuim.ie>
Signed-off-by: Doug Leith <doug.leith@nuim.ie>
diff --git a/net/ipv4/tcp_htcp.c b/net/ipv4/tcp_htcp.c
index 6edfe5e..8072b6d 100644
--- a/net/ipv4/tcp_htcp.c
+++ b/net/ipv4/tcp_htcp.c
@@ -23,7 +23,7 @@ module_param(use_bandwidth_switch, int,
MODULE_PARM_DESC(use_bandwidth_switch, "turn on/off bandwidth switcher");
struct htcp {
- u16 alpha; /* Fixed point arith, << 7 */
+ u32 alpha; /* Fixed point arith, << 7 */
u8 beta; /* Fixed point arith, << 7 */
u8 modeswitch; /* Delay modeswitch until we had at least one congestion event */
u32 last_cong; /* Time since last congestion event end */
next reply other threads:[~2006-10-24 14:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 14:17 Gavin McCullagh [this message]
2006-10-24 22:30 ` [PATCH] fix integer overflow in H-TCP congestion control David Miller
2006-10-25 8:47 ` Gavin McCullagh
2006-10-26 6:06 ` David Miller
2006-10-31 18:48 ` [RFC, PATCH] dont insert sockets/pipes dentries into dentry_hashtable Eric Dumazet
2006-11-01 7:19 ` David Miller
2006-11-01 8:21 ` Eric Dumazet
2006-11-01 8:34 ` David Miller
2006-11-01 8:38 ` Al Viro
2006-11-01 8:42 ` Al Viro
2006-11-01 9:04 ` Eric Dumazet
2006-11-01 13:54 ` Eric Dumazet
2006-11-22 18:00 ` [PATCH] [NET] dont insert socket " Eric Dumazet
2006-11-28 23:35 ` David Miller
2006-11-29 0:13 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061024141739.GB18364@nuim.ie \
--to=gavin.mccullagh@nuim.ie \
--cc=baruch@ev-en.org \
--cc=doug.leith@nuim.ie \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).