From: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
To: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Greg KH <gregkh-l3A5Bk7waGM@public.gmane.org>,
bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
Larry Finger
<Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Subject: Re: Fwd: [PATCH] bcm43xx: (hopefully) fix watchdog timeouts.
Date: Wed, 25 Oct 2006 11:38:38 +0200 [thread overview]
Message-ID: <200610251138.39036.mb@bu3sch.de> (raw)
In-Reply-To: <20061025003726.GC7340-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
On Wednesday 25 October 2006 02:37, John W. Linville wrote:
> Michael,
>
> It looks like you have a patch that I don't have, one that moves the
> netif_tx_disable and spin_lock_irqsave outside of the "if (badness >
> BADNESS_LIMIT)" conditional.
>
> Could you pass that one along as well, or correct this patch to match
> what is in Linus' tree?
Well, I'm not sure who moved the tx_disable outside of the
conditional. It is not needed. We only need to disable TX on
the slowpath (the first branch of the if condition). It does not
hurt to disable it always, though.
But I will send a new patch against wireless-2.6, which only disables
TX for the slowpath and fakes a TX there.
But for Greg, the original patch is ok.
How was the stable mailing list again? stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org seems to bounce.
--
Greetings Michael.
next prev parent reply other threads:[~2006-10-25 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 14:31 Fwd: [PATCH] bcm43xx: (hopefully) fix watchdog timeouts Michael Buesch
2006-10-24 14:32 ` Michael Buesch
[not found] ` <200610241631.18911.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2006-10-25 0:28 ` John W. Linville
2006-10-25 0:37 ` John W. Linville
[not found] ` <20061025003726.GC7340-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2006-10-25 9:38 ` Michael Buesch [this message]
2006-10-26 4:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610251138.39036.mb@bu3sch.de \
--to=mb-fseuscv1ubazqb+pc5nmwq@public.gmane.org \
--cc=Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org \
--cc=bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).