From: Stephen Hemminger <shemminger@osdl.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/8] netpoll: skb private pool management
Date: Thu, 26 Oct 2006 18:04:02 -0700 [thread overview]
Message-ID: <20061026180402.32c1c511@localhost.localdomain> (raw)
In-Reply-To: <20061026.171247.133285493.davem@davemloft.net>
On Thu, 26 Oct 2006 17:12:47 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Thu, 26 Oct 2006 15:46:49 -0700
>
> > @@ -188,19 +186,14 @@ void netpoll_poll(struct netpoll *np)
> > static void refill_skbs(void)
> > {
> > struct sk_buff *skb;
> > - unsigned long flags;
> >
> > - spin_lock_irqsave(&skb_list_lock, flags);
> > - while (nr_skbs < MAX_SKBS) {
> > + while (skb_queue_len(&skb_pool) < MAX_SKBS) {
>
> Previously, the lock actually protected nr_skbs from going over
> MAX_SKBS properly, but the new code does not. skb_queue_len()
> is lockless.
>
> Stephen, I really appreciate your efforts to clean up netpoll,
> but on every iteration I am finding simple errors on the first
> patch every time.
racing over by one is not a big issue.
next prev parent reply other threads:[~2006-10-27 1:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-26 22:46 [PATCH 0/8] netpoll: A Halloween horror mystery Stephen Hemminger
2006-10-26 22:46 ` [PATCH 1/8] netpoll: skb private pool management Stephen Hemminger
2006-10-27 0:12 ` David Miller
2006-10-27 1:04 ` Stephen Hemminger [this message]
2006-10-27 1:08 ` David Miller
2006-10-27 2:29 ` Stephen Hemminger
2006-11-14 1:00 ` David Miller
2006-11-14 21:55 ` netpoll patches Stephen Hemminger
2006-11-15 4:43 ` David Miller
2006-10-26 22:46 ` [PATCH 2/8] netpoll info leak Stephen Hemminger
2006-10-26 22:46 ` [PATCH 3/8] netpoll per device txq Stephen Hemminger
2006-10-26 22:46 ` [PATCH 4/8] netpoll setup error handling Stephen Hemminger
2006-10-26 22:46 ` [PATCH 5/8] netpoll deferred transmit path Stephen Hemminger
2006-10-26 22:46 ` [PATCH 6/8] netpoll retry cleanup Stephen Hemminger
2006-10-26 22:46 ` [PATCH 7/8] netpoll queue cleanup Stephen Hemminger
2006-10-26 22:46 ` [PATCH 8/8] netpoll header cleanup Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061026180402.32c1c511@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).