netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: David Miller <davem@davemloft.net>
Cc: hagen@jauu.net, jheffner@psc.edu, netdev@vger.kernel.org
Subject: Re: [PATCH] tcp: don't allow unfair congestion control to be built without warning
Date: Fri, 27 Oct 2006 17:48:16 -0700	[thread overview]
Message-ID: <20061027174816.29bd6563@localhost.localdomain> (raw)
In-Reply-To: <20061027.152444.48528262.davem@davemloft.net>

How about another way of controlling this via sysctl.

First, add code to for read only:
	/proc/sys/net/ipv4/tcp_available_congestion_control  (or shorter name)
this will show all things compiled in (even if not loaded yet). Similar
to /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_frequencies

Second, add flag (allowed) to the tcp_congestion structure [inverse of
earlier restricted]

Third, add read-write
	/proc/sys/net/ipv4/tcp_allowed_congestion_control
to show and set/clear the allowed flag. Default value would be
"reno xxx" where xxx is what ever the default value from the kernel
config is (currently cubic).

I would use sysfs for this, but it make sense not to spread TCP stuff into
both sysctl and sysfs.

  reply	other threads:[~2006-10-28  0:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-25 18:08 [RFC] tcp: setsockopt congestion control autoload Stephen Hemminger
2006-10-25 23:21 ` Patrick McHardy
2006-10-26  5:22 ` Evgeniy Polyakov
2006-10-26 14:34   ` Stephen Hemminger
2006-10-26 14:57     ` Evgeniy Polyakov
2006-10-26 15:23       ` Stephen Hemminger
2006-10-26 17:05         ` Patrick McHardy
2006-10-26 20:55       ` David Miller
2006-10-26 17:29 ` John Heffner
2006-10-26 20:57   ` David Miller
2006-10-26 22:44   ` Hagen Paul Pfeifer
2006-10-26 22:53     ` John Heffner
2006-10-26 23:52     ` [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm Hagen Paul Pfeifer
2006-10-26 23:59       ` Ian McDonald
2006-10-27  0:07         ` David Miller
2006-10-27  0:20           ` Ian McDonald
2006-10-27  0:02       ` David Miller
2006-10-27 10:43         ` Hagen Paul Pfeifer
2006-10-27 14:41           ` Stephen Hemminger
2006-10-27 15:21             ` Hagen Paul Pfeifer
2006-10-27 15:48               ` Stephen Hemminger
2006-10-27 17:30                 ` [PATCH] tcp: don't allow unfair congestion control to be built without warning Stephen Hemminger
2006-10-27 17:43                   ` John Heffner
2006-10-27 17:59                     ` [PATCH] tcp: allow restricting congestion control choices Stephen Hemminger
2006-10-27 21:17                   ` [PATCH] tcp: don't allow unfair congestion control to be built without warning David Miller
2006-10-27 21:24                     ` Stephen Hemminger
2006-10-27 21:37                       ` David Miller
2006-10-27 21:59                         ` Stephen Hemminger
2006-10-27 22:12                           ` David Miller
2006-10-27 22:21                             ` Stephen Hemminger
2006-10-27 22:24                               ` David Miller
2006-10-28  0:48                                 ` Stephen Hemminger [this message]
2006-10-28  3:10                                   ` [RFC] tcp: available congetsion control Stephen Hemminger
2006-10-27 21:22             ` [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm David Miller
2006-10-27  1:03       ` Stephen Hemminger
2006-10-27 18:14 ` [PATCH] tcp: setsockopt congestion control autoload Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061027174816.29bd6563@localhost.localdomain \
    --to=shemminger@osdl.org \
    --cc=davem@davemloft.net \
    --cc=hagen@jauu.net \
    --cc=jheffner@psc.edu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).