netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org, sri@us.ibm.com
Subject: Re: [SCTP]: Always linearise packet on input
Date: Sun, 29 Oct 2006 23:46:19 -0800 (PST)	[thread overview]
Message-ID: <20061029.234619.112618588.davem@davemloft.net> (raw)
In-Reply-To: <20061030071128.GA15715@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 30 Oct 2006 18:11:28 +1100

> [SCTP]: Always linearise packet on input
 ...
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

I'll apply this, thanks a lot.

> Sridhar, could you please organise an audit of SCTP to make sure
> that it deals with skb fragments (both pages and frag_list) in a
> safe manner? Basically before you do an skb_pull or access skb->data
> you must ensure that the data you want to access is in the head,
> usually by doing skb_may_pull.  Of course, for large payloads it
> helps if you can avoid pulling it into the head.

Of course, you mean "pskb_may_pull" here.
:-)

  reply	other threads:[~2006-10-30  7:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-30  7:11 [SCTP]: Always linearise packet on input Herbert Xu
2006-10-30  7:46 ` David Miller [this message]
2006-10-31  1:31   ` Sridhar Samudrala
2006-10-31  3:01     ` Herbert Xu
2006-10-31 14:36       ` Vlad Yasevich
2006-10-31 18:18         ` Sridhar Samudrala
2006-10-31 18:46           ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061029.234619.112618588.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=sri@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).