From: Ray Lehtiniemi <rayl@mail.com>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: jeff@garzik.org, netdev@vger.kernel.org,
Herbert Valerio Riedel <hvr@gnu.org>
Subject: Re: [PATCH 3/3] ep93xx_eth: don't report RX FIFO overrun errors
Date: Sun, 29 Oct 2006 11:15:28 -0700 [thread overview]
Message-ID: <200610291115.29428.rayl@mail.com> (raw)
In-Reply-To: <20061029130649.GD6900@xi.wantstofly.org>
On Sunday 29 October 2006 06:06, Lennert Buytenhek wrote:
> Flooding the console with an RX FIFO overrun error for every single
> dropped packet isn't very sensible. The hardware is very underpowered
> according to today's standards, and RX FIFO overrun errors can be
> triggered quite easily, so don't report them at all.
>
> Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
>
> Index: linux-2.6.19-rc3/drivers/net/arm/ep93xx_eth.c
> ===================================================================
> --- linux-2.6.19-rc3.orig/drivers/net/arm/ep93xx_eth.c
> +++ linux-2.6.19-rc3/drivers/net/arm/ep93xx_eth.c
> @@ -230,8 +230,9 @@ static int ep93xx_rx(struct net_device *
> " %.8x %.8x\n", rstat0, rstat1);
>
> if (!(rstat0 & RSTAT0_RWE)) {
> - printk(KERN_NOTICE "ep93xx_rx: receive error "
> - " %.8x %.8x\n", rstat0, rstat1);
> + if (!(rstat0 & RSTAT_OE))
> + printk(KERN_NOTICE "ep93xx_rx: receive error "
> + " %.8x %.8x\n", rstat0, rstat1);
>
> ep->stats.rx_errors++;
> if (rstat0 & RSTAT0_OE)
i got a compile error: please s/RSTAT_OE/RSTAT0_OE/ in this patch. Also, is
it possible for any other error bits to be set at the same time as OE? such
bits would not be printed to the log in this case.
ray
next prev parent reply other threads:[~2006-10-29 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 13:06 [PATCH 3/3] ep93xx_eth: don't report RX FIFO overrun errors Lennert Buytenhek
2006-10-29 18:15 ` Ray Lehtiniemi [this message]
2006-10-29 18:22 ` Lennert Buytenhek
2006-10-29 18:41 ` Ray Lehtiniemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610291115.29428.rayl@mail.com \
--to=rayl@mail.com \
--cc=buytenh@wantstofly.org \
--cc=hvr@gnu.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).