* [patch] make sch_fifo.o available when CONFIG_NET_SCHED is not set
@ 2006-10-31 16:53 David Kimdon
2006-10-31 23:24 ` Thomas Graf
0 siblings, 1 reply; 4+ messages in thread
From: David Kimdon @ 2006-10-31 16:53 UTC (permalink / raw)
To: netdev; +Cc: Patrick McHardy, David S. Miller
[-- Attachment #1: config_net_sch_fifo.patch --]
[-- Type: text/plain, Size: 2302 bytes --]
You may see this discussion for more info:
http://marc.theaimsgroup.com/?t=116181395100002&r=1&w=2
----
Based on a patch by Patrick McHardy.
Add a new option, NET_SCH_FIFO, which provides a simple fifo qdisc
without requiring CONFIG_NET_SCHED.
The d80211 stack needs a generic fifo qdisc for WME. At present it
uses net/d80211/fifo_qdisc.c which is functionally equivalent to
sch_fifo.c. This patch will allow the d80211 stack to remove
net/d80211/fifo_qdisc.c and use sch_fifo.c instead.
Signed-off-by: David Kimdon <david.kimdon@devicescape.com>
Index: wireless-dev/net/sched/Kconfig
===================================================================
--- wireless-dev.orig/net/sched/Kconfig
+++ wireless-dev/net/sched/Kconfig
@@ -6,6 +6,7 @@ menu "QoS and/or fair queueing"
config NET_SCHED
bool "QoS and/or fair queueing"
+ select NET_SCH_FIFO
---help---
When the kernel has several packets to send out over a network
device, it has to decide which ones to send first, which ones to
@@ -40,6 +41,15 @@ config NET_SCHED
The available schedulers are listed in the following questions; you
can say Y to as many as you like. If unsure, say N now.
+config NET_SCH_FIFO
+ tristate "Simple Fifo Qdisc (PFIFO, BFIFO)"
+ ---help---
+ Say Y here if you want to use the simple pfifo or bfifo
+ packet scheduling algorithms.
+
+ To compile this code as a module, choose M here: the
+ module will be called sch_fifo.
+
if NET_SCHED
choice
Index: wireless-dev/net/sched/Makefile
===================================================================
--- wireless-dev.orig/net/sched/Makefile
+++ wireless-dev/net/sched/Makefile
@@ -4,7 +4,7 @@
obj-y := sch_generic.o
-obj-$(CONFIG_NET_SCHED) += sch_api.o sch_fifo.o sch_blackhole.o
+obj-$(CONFIG_NET_SCHED) += sch_api.o sch_blackhole.o
obj-$(CONFIG_NET_CLS) += cls_api.o
obj-$(CONFIG_NET_CLS_ACT) += act_api.o
obj-$(CONFIG_NET_ACT_POLICE) += act_police.o
@@ -14,6 +14,7 @@ obj-$(CONFIG_NET_ACT_MIRRED) += act_mirr
obj-$(CONFIG_NET_ACT_IPT) += act_ipt.o
obj-$(CONFIG_NET_ACT_PEDIT) += act_pedit.o
obj-$(CONFIG_NET_ACT_SIMP) += act_simple.o
+obj-$(CONFIG_NET_SCH_FIFO) += sch_fifo.o
obj-$(CONFIG_NET_SCH_CBQ) += sch_cbq.o
obj-$(CONFIG_NET_SCH_HTB) += sch_htb.o
obj-$(CONFIG_NET_SCH_HPFQ) += sch_hpfq.o
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] make sch_fifo.o available when CONFIG_NET_SCHED is not set
2006-10-31 16:53 [patch] make sch_fifo.o available when CONFIG_NET_SCHED is not set David Kimdon
@ 2006-10-31 23:24 ` Thomas Graf
2006-11-08 14:06 ` David Kimdon
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Graf @ 2006-10-31 23:24 UTC (permalink / raw)
To: David Kimdon; +Cc: netdev, Patrick McHardy, David S. Miller
* David Kimdon <david.kimdon@devicescape.com> 2006-10-31 08:53
> You may see this discussion for more info:
> http://marc.theaimsgroup.com/?t=116181395100002&r=1&w=2
>
> ----
> Based on a patch by Patrick McHardy.
>
> Add a new option, NET_SCH_FIFO, which provides a simple fifo qdisc
> without requiring CONFIG_NET_SCHED.
>
> The d80211 stack needs a generic fifo qdisc for WME. At present it
> uses net/d80211/fifo_qdisc.c which is functionally equivalent to
> sch_fifo.c. This patch will allow the d80211 stack to remove
> net/d80211/fifo_qdisc.c and use sch_fifo.c instead.
I think NET_SCH_FIFO doesn't need a help text, should be invisible
to the user. Just select it from NET_SCHED and d80211.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] make sch_fifo.o available when CONFIG_NET_SCHED is not set
2006-10-31 23:24 ` Thomas Graf
@ 2006-11-08 14:06 ` David Kimdon
2006-11-10 0:17 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: David Kimdon @ 2006-11-08 14:06 UTC (permalink / raw)
To: Thomas Graf; +Cc: netdev, Patrick McHardy, David S. Miller
On Wed, Nov 01, 2006 at 12:24:01AM +0100, Thomas Graf wrote:
> I think NET_SCH_FIFO doesn't need a help text, should be invisible
> to the user. Just select it from NET_SCHED and d80211.
sure, here is a new one:
----
Based on patch by Patrick McHardy.
Add a new option, NET_SCH_FIFO, which provides a simple fifo qdisc
without requiring CONFIG_NET_SCHED.
The d80211 stack needs a generic fifo qdisc for WME. At present it
uses net/d80211/fifo_qdisc.c which is functionally equivalent to
sch_fifo.c. This patch will allow the d80211 stack to remove
net/d80211/fifo_qdisc.c and use sch_fifo.c instead.
Signed-off-by: David Kimdon <david.kimdon@devicescape.com>
Index: wireless-dev/net/sched/Kconfig
===================================================================
--- wireless-dev.orig/net/sched/Kconfig
+++ wireless-dev/net/sched/Kconfig
@@ -6,6 +6,7 @@ menu "QoS and/or fair queueing"
config NET_SCHED
bool "QoS and/or fair queueing"
+ select NET_SCH_FIFO
---help---
When the kernel has several packets to send out over a network
device, it has to decide which ones to send first, which ones to
@@ -40,6 +41,9 @@ config NET_SCHED
The available schedulers are listed in the following questions; you
can say Y to as many as you like. If unsure, say N now.
+config NET_SCH_FIFO
+ bool
+
if NET_SCHED
choice
Index: wireless-dev/net/sched/Makefile
===================================================================
--- wireless-dev.orig/net/sched/Makefile
+++ wireless-dev/net/sched/Makefile
@@ -4,7 +4,7 @@
obj-y := sch_generic.o
-obj-$(CONFIG_NET_SCHED) += sch_api.o sch_fifo.o sch_blackhole.o
+obj-$(CONFIG_NET_SCHED) += sch_api.o sch_blackhole.o
obj-$(CONFIG_NET_CLS) += cls_api.o
obj-$(CONFIG_NET_CLS_ACT) += act_api.o
obj-$(CONFIG_NET_ACT_POLICE) += act_police.o
@@ -14,6 +14,7 @@ obj-$(CONFIG_NET_ACT_MIRRED) += act_mirr
obj-$(CONFIG_NET_ACT_IPT) += act_ipt.o
obj-$(CONFIG_NET_ACT_PEDIT) += act_pedit.o
obj-$(CONFIG_NET_ACT_SIMP) += act_simple.o
+obj-$(CONFIG_NET_SCH_FIFO) += sch_fifo.o
obj-$(CONFIG_NET_SCH_CBQ) += sch_cbq.o
obj-$(CONFIG_NET_SCH_HTB) += sch_htb.o
obj-$(CONFIG_NET_SCH_HPFQ) += sch_hpfq.o
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] make sch_fifo.o available when CONFIG_NET_SCHED is not set
2006-11-08 14:06 ` David Kimdon
@ 2006-11-10 0:17 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2006-11-10 0:17 UTC (permalink / raw)
To: david.kimdon; +Cc: tgraf, netdev, kaber
From: David Kimdon <david.kimdon@devicescape.com>
Date: Wed, 8 Nov 2006 06:06:18 -0800
> Based on patch by Patrick McHardy.
>
> Add a new option, NET_SCH_FIFO, which provides a simple fifo qdisc
> without requiring CONFIG_NET_SCHED.
>
> The d80211 stack needs a generic fifo qdisc for WME. At present it
> uses net/d80211/fifo_qdisc.c which is functionally equivalent to
> sch_fifo.c. This patch will allow the d80211 stack to remove
> net/d80211/fifo_qdisc.c and use sch_fifo.c instead.
>
> Signed-off-by: David Kimdon <david.kimdon@devicescape.com>
Applied to net-2.6.20, thanks David.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-11-10 0:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-31 16:53 [patch] make sch_fifo.o available when CONFIG_NET_SCHED is not set David Kimdon
2006-10-31 23:24 ` Thomas Graf
2006-11-08 14:06 ` David Kimdon
2006-11-10 0:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).