From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled Date: Tue, 31 Oct 2006 19:07:12 +0100 Message-ID: <20061031180712.GQ27968@stusta.de> References: <200610281410.13679.david-b@pacbell.net> <20061028213918.GE27968@stusta.de> <200610310940.16619.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-usb-devel@lists.sourceforge.net, Randy Dunlap , akpm@osdl.org, zippel@linux-m68k.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, link@miggy.org, Christoph Hellwig , torvalds@osdl.org, greg@kroah.com, toralf.foerster@gmx.de Return-path: Received: from mailout.stusta.mhn.de ([141.84.69.5]:9999 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1423724AbWJaSHN (ORCPT ); Tue, 31 Oct 2006 13:07:13 -0500 To: David Brownell Content-Disposition: inline In-Reply-To: <200610310940.16619.david-b@pacbell.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Oct 31, 2006 at 10:40:15AM -0700, David Brownell wrote: > > > > +#if defined(CONFIG_MII) || defined(CONFIG_MII_MODULE) > > > +#define HAVE_MII > > >... > > > > This seems to cause a CONFIG_USB_USBNET=y, CONFIG_MII=m breakage > > (as already described earlier in this thread)? > > Well, "alluded to" not described. Fixable by the equivalent of > > config USB_USBNET > ... > depends on MII if MII != n > > except that Kconfig doesn't comprehend conditionals like that. You can express this in Kconfig: depends MII || MII=n But my suggestion was: #if defined(CONFIG_MII) || (defined(CONFIG_MII_MODULE) && defined(MODULE)) Or simply select MII ... cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed