From: David Miller <davem@davemloft.net>
To: wharms@bfs.de
Cc: kernel-janitors@lists.osdl.org,
tipc-discussion@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [KJ] [patch] net/tipc: sprintf/strcpy conversion
Date: Wed, 01 Nov 2006 15:19:17 -0800 (PST) [thread overview]
Message-ID: <20061101.151917.133285028.davem@davemloft.net> (raw)
In-Reply-To: <454913D2.9050608@bfs.de>
From: walter harms <wharms@bfs.de>
Date: Wed, 01 Nov 2006 22:38:26 +0100
> These line
> + strcpy(bcbearer->media.name, "tipc-multicast");
>
> i gues that means tipc_bclink_name ?
Why? The original code used "tipc-multicast" which is a
different string than tipc_bclink_name which is "multicast-link".
> > - sprintf(bcbearer->media.name, "tipc-multicast");
> > + strcpy(bcbearer->media.name, "tipc-multicast");
If you are arguing that it should be changed, that's a different
changeset to discuss.
next prev parent reply other threads:[~2006-11-01 23:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 14:06 [patch] net/tipc: sprintf/strcpy conversion Florian Westphal
2006-11-01 21:38 ` [KJ] " walter harms
2006-11-01 23:19 ` David Miller [this message]
2006-11-02 7:45 ` walter harms
2006-11-02 6:26 ` [tipc-discussion] " Florian Westphal
2006-11-02 7:57 ` [KJ] [tipc-discussion] " walter harms
2006-11-03 0:09 ` [KJ] " Alexey Dobriyan
2006-11-03 10:50 ` Hagen Paul Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061101.151917.133285028.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel-janitors@lists.osdl.org \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).