Re: [PATCH] warning in SCTP

[David Miller <davem@davemloft.net>]

From: Meelis Roos <mroos@linux.ee>
Date: Thu, 2 Nov 2006 09:29:16 +0200 (EET)

>    CC [M]  net/sctp/sm_make_chunk.o
> net/sctp/sm_make_chunk.c: In function 'sctp_unpack_cookie':
> net/sctp/sm_make_chunk.c:1358: warning: initialization discards qualifiers from pointer target type
> 
> The reason is that sctp_unpack_cookie() takes a const struct 
> sctp_endpoint and modifies the digest in it (digest being embedded in 
> the struct, not a pointer). So sctp_unpack_cookie really does not use 
> the argument as const, mark it as such.
> 
> Signed-off-by: Meelis Roos <mroos@linux.ee>

Applied, but like your other patch I had to apply it by hand.

Something in your email client adds extra spaces to the patch,
for example:

> diff --git a/include/net/sctp/sm.h b/include/net/sctp/sm.h
> index de313de..ef80489 100644
> --- a/include/net/sctp/sm.h
> +++ b/include/net/sctp/sm.h
> @@ -272,7 +272,7 @@ void sctp_generate_heartbeat_event(unsig
> 
>   void sctp_ootb_pkt_free(struct sctp_packet *);
> 

There should only be one space before the "void" in the patch,
your email client (or something else) put another space there.

Also, your email client likes to turn lines containing only
spaces into empty lines, which also corrupts the patch.