From: "John W. Linville" <linville@tuxdriver.com>
To: David Kimdon <david.kimdon@devicescape.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, Jiri Benc <jbenc@suse.cz>
Subject: Re: [take1] d80211: switch crypto to use new ciphers API
Date: Thu, 2 Nov 2006 21:10:27 -0500 [thread overview]
Message-ID: <20061103021021.GC2989@tuxdriver.com> (raw)
In-Reply-To: <20061030180858.GA12593@devicescape.com>
On Mon, Oct 30, 2006 at 10:08:58AM -0800, David Kimdon wrote:
> On Thu, Oct 26, 2006 at 10:06:24AM +1000, Herbert Xu wrote:
> > If you're only encrypting/decrypting a single block then you should
> > use the cipher interface. So net/d80211/aes_ccm.c should do that
> > instead. See drivers/net/wirless/airo.c for an example of that.
>
> Thanks Herbert.
>
> Updated patch, now aes, tkip and wep are all tested.
>
> Changes from take0:
>
> Use IS_ERR() to evaluate return value of crypto_alloc_cipher(). Use
> ciper interface rather than blkcipher for aes encryption since we only
> encrypt a single block at a time.
>
> --------
>
> Switch d80211 software crypto to use the new cipher API.
Applied to wireless-dev.
--
John W. Linville
linville@tuxdriver.com
prev parent reply other threads:[~2006-11-03 2:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-25 22:41 [RFC] d80211: switch crypto to use block ciphers David Kimdon
2006-10-26 0:06 ` Herbert Xu
2006-10-30 18:08 ` [take1] d80211: switch crypto to use new ciphers API David Kimdon
2006-10-31 1:03 ` Herbert Xu
2006-11-03 2:10 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061103021021.GC2989@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=david.kimdon@devicescape.com \
--cc=herbert@gondor.apana.org.au \
--cc=jbenc@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).