From: Stephen Hemminger <shemminger@osdl.org>
To: Jens Osterkamp <jens@de.ibm.com>, Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH] spider_net: access class_device to find irq
Date: Mon, 6 Nov 2006 13:18:01 -0800 [thread overview]
Message-ID: <20061106131801.31242512@freekitty> (raw)
Spider net should be using netdev->irq to find irq not "dumpster diving"
off into the PCI device. This code breaks in -mm when class_device
is eliminated.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- a/drivers/net/spider_net.c 2006-11-06 13:11:48.000000000 -0800
+++ b/drivers/net/spider_net.c 2006-11-06 13:12:50.000000000 -0800
@@ -1919,8 +1919,7 @@
spider_net_write_reg(card, SPIDER_NET_GHIINT1MSK, 0);
spider_net_write_reg(card, SPIDER_NET_GHIINT2MSK, 0);
- /* free_irq(netdev->irq, netdev);*/
- free_irq(to_pci_dev(netdev->class_dev.dev)->irq, netdev);
+ free_irq(netdev->irq, netdev);
spider_net_write_reg(card, SPIDER_NET_GDTDMACCNTR,
SPIDER_NET_DMA_TX_FEND_VALUE);
reply other threads:[~2006-11-06 21:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061106131801.31242512@freekitty \
--to=shemminger@osdl.org \
--cc=jens@de.ibm.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox