* [PATCH] spider_net: access class_device to find irq
@ 2006-11-06 21:18 Stephen Hemminger
0 siblings, 0 replies; only message in thread
From: Stephen Hemminger @ 2006-11-06 21:18 UTC (permalink / raw)
To: Jens Osterkamp, Jeff Garzik; +Cc: netdev
Spider net should be using netdev->irq to find irq not "dumpster diving"
off into the PCI device. This code breaks in -mm when class_device
is eliminated.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- a/drivers/net/spider_net.c 2006-11-06 13:11:48.000000000 -0800
+++ b/drivers/net/spider_net.c 2006-11-06 13:12:50.000000000 -0800
@@ -1919,8 +1919,7 @@
spider_net_write_reg(card, SPIDER_NET_GHIINT1MSK, 0);
spider_net_write_reg(card, SPIDER_NET_GHIINT2MSK, 0);
- /* free_irq(netdev->irq, netdev);*/
- free_irq(to_pci_dev(netdev->class_dev.dev)->irq, netdev);
+ free_irq(netdev->irq, netdev);
spider_net_write_reg(card, SPIDER_NET_GDTDMACCNTR,
SPIDER_NET_DMA_TX_FEND_VALUE);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-11-06 21:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-06 21:18 [PATCH] spider_net: access class_device to find irq Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).