From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: bunk@stusta.de, jgarzik@pobox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: tg3_read_partno(): possible array overrun
Date: Tue, 07 Nov 2006 14:58:09 -0800 (PST) [thread overview]
Message-ID: <20061107.145809.132301902.davem@davemloft.net> (raw)
In-Reply-To: <1162843651.3409.5.camel@rh4>
From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 06 Nov 2006 12:07:31 -0800
> On Mon, 2006-11-06 at 10:45 +0100, Adrian Bunk wrote:
> > The Coverity checker noted the following in drivers/net/tg3.c:
> >
> > <-- snip -->
> >
> > The problem is that vpd_data[i + 2] could be vpd_data[255 + 2].
>
> Thanks. This should fix it:
>
> [TG3]: Fix array overrun in tg3_read_partno().
>
> Use proper upper limits for the loops and check for all error
> conditions.
>
> The problem was noticed by Adrian Bunk.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks Michael.
prev parent reply other threads:[~2006-11-07 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 9:45 tg3_read_partno(): possible array overrun Adrian Bunk
2006-11-06 20:07 ` Michael Chan
2006-11-07 22:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061107.145809.132301902.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).