From: Ingo Oeser <netdev@axxeo.de>
To: "Amit S. Kale" <amitkale@netxen.com>
Cc: netdev@vger.kernel.org, jeff@garzik.org,
Sanjeev Jorapur <sanjeev@netxen.com>, Rob Mapes <rob@netxen.com>,
wendyx@us.ibm.com, brazilnut@us.ibm.com,
netxenproj@linsyssoft.com
Subject: Re: [PATCH 1/3] NetXen: Fixed /sys mapping between device and driver
Date: Tue, 7 Nov 2006 17:49:10 +0100 [thread overview]
Message-ID: <200611071749.11359.netdev@axxeo.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0611070835060.26206@dut39>
Hi Amit,
one minor nitpick:
You wrote:
> diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
> index b54ea16..4effb87 100644
> --- a/drivers/net/netxen/netxen_nic_main.c
> +++ b/drivers/net/netxen/netxen_nic_main.c
[...]
> @@ -1040,7 +1041,7 @@ static int netxen_nic_poll(struct net_de
> netxen_nic_enable_int(adapter);
> }
>
> - return (done ? 0 : 1);
> + return (!done);
return !done;
Please lose the braces here (CodingStyle).
Just respin or send this change along with later patchsets.
Regards
Ingo Oeser
next prev parent reply other threads:[~2006-11-07 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-07 16:33 [PATCH 0/3] NetXen: 1G/10G Ethernet Driver updates Amit S. Kale
2006-11-07 16:38 ` [PATCH 1/3] NetXen: Fixed /sys mapping between device and driver Amit S. Kale
2006-11-07 16:49 ` Ingo Oeser [this message]
2006-11-08 6:07 ` Amit S. Kale
2006-11-14 15:26 ` Jeff Garzik
2006-11-07 16:44 ` [PATCH 2/3] NetXen: 1G/10G Ethernet Driver updates Amit S. Kale
2006-11-07 17:02 ` [PATCH 3/3] " Amit S. Kale
-- strict thread matches above, loose matches on Subject: below --
2006-11-17 15:25 [PATCH 1/3] NetXen: Fixed /sys mapping between device and driver Linsys Contractor Amit S. Kale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611071749.11359.netdev@axxeo.de \
--to=netdev@axxeo.de \
--cc=amitkale@netxen.com \
--cc=brazilnut@us.ibm.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=netxenproj@linsyssoft.com \
--cc=rob@netxen.com \
--cc=sanjeev@netxen.com \
--cc=wendyx@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).