From: Andrew Morton <akpm@osdl.org>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, NetDev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: e1000: include <net/ip6_checksum.h> for IA64
Date: Wed, 8 Nov 2006 11:06:01 -0800 [thread overview]
Message-ID: <20061108110601.01d9a4f4.akpm@osdl.org> (raw)
In-Reply-To: <45521873.20402@intel.com>
On Wed, 08 Nov 2006 09:48:35 -0800
Auke Kok <auke-jan.h.kok@intel.com> wrote:
> Here's a slightly better patch to fix ia64 not building atm.
fsvo "better".
> Jeff, please apply this to netdev-2.6#upstream instead of akpm's patch that I acked earlier.
>
> Of course, someone really should come up with an asm version for ia64 of the missing
> function ;)
>
> Cheers,
>
> Auke
>
> ---
>
> e1000: include <net/ip6_checksum.h> for IA64
>
> IA64 does not have an optimized asm version for ipv6 csum magic. Fall
> back to generic implementation.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
>
> diff --git a/drivers/net/e1000/e1000.h b/drivers/net/e1000/e1000.h
> index f091042..26e7506 100644
> --- a/drivers/net/e1000/e1000.h
> +++ b/drivers/net/e1000/e1000.h
> @@ -61,6 +61,7 @@
> #include <linux/ip.h>
> #ifdef NETIF_F_TSO6
> #include <linux/ipv6.h>
> +#include <net/ip6_checksum.h>
> #endif
> #include <linux/tcp.h>
> #include <linux/udp.h>
It is noxious of e1000 to do a #include <everything.h> from its driver-wide
header file and I refused to be a party to such a thing!
Jeff probably won't be able to apply this because, like your other patches,
it is space-stuffed. Then again, maybe git understands format=flowed, dunno.
next prev parent reply other threads:[~2006-11-08 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-08 17:48 e1000: include <net/ip6_checksum.h> for IA64 Auke Kok
2006-11-08 19:06 ` Andrew Morton [this message]
2006-11-09 0:10 ` Chen, Kenneth W
-- strict thread matches above, loose matches on Subject: below --
2006-11-09 0:32 Chen, Kenneth W
2006-11-09 2:07 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061108110601.01d9a4f4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=auke-jan.h.kok@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).