* [DECnet] Don't clear memory twice.
@ 2006-11-08 15:45 Ralf Baechle
2006-11-09 7:02 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2006-11-08 15:45 UTC (permalink / raw)
To: netdev, David S. Miller; +Cc: SteveW
When dn_neigh.c was converted from kmalloc to kzalloc in commit
0da974f4f303a6842516b764507e3c0a03f41e5a it was missed that
dn_neigh_seq_open was actually clearing the allocation twice was
missed.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/net/decnet/dn_neigh.c b/net/decnet/dn_neigh.c
index ff0ebe9..7322bb3 100644
--- a/net/decnet/dn_neigh.c
+++ b/net/decnet/dn_neigh.c
@@ -591,7 +591,6 @@ static int dn_neigh_seq_open(struct inod
seq = file->private_data;
seq->private = s;
- memset(s, 0, sizeof(*s));
out:
return rc;
out_kfree:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [DECnet] Don't clear memory twice.
2006-11-08 15:45 [DECnet] Don't clear memory twice Ralf Baechle
@ 2006-11-09 7:02 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-11-09 7:02 UTC (permalink / raw)
To: ralf; +Cc: netdev, SteveW
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 8 Nov 2006 15:45:07 +0000
> When dn_neigh.c was converted from kmalloc to kzalloc in commit
> 0da974f4f303a6842516b764507e3c0a03f41e5a it was missed that
> dn_neigh_seq_open was actually clearing the allocation twice was
> missed.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Applied, thanks a lot Ralf.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-09 7:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-08 15:45 [DECnet] Don't clear memory twice Ralf Baechle
2006-11-09 7:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).