netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re. Please pull 'upstream' branch of wireless-2.6
@ 2006-11-08 17:27 Roger While
  2006-11-08 19:46 ` John W. Linville
  0 siblings, 1 reply; 6+ messages in thread
From: Roger While @ 2006-11-08 17:27 UTC (permalink / raw)
  To: netdev

John, you just broke a considerable number of prism54 users.
It is NOT an error if the MWI set fails. This is just a
performance tweak and has NO effect on the driver working.

Roger While



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re. Please pull 'upstream' branch of wireless-2.6
@ 2006-11-09  8:24 Roger While
  0 siblings, 0 replies; 6+ messages in thread
From: Roger While @ 2006-11-09  8:24 UTC (permalink / raw)
  To: netdev; +Cc: linville

John wrote :
>Yeah, looks like I was a bit overzealous on the warning squelch...
>
>I'll cook-up a new patch that doesn't error-out.

I hope you do not bloat the kernel with meaningless warning messages.
Something simple like the following will do.

         /* enable MWI */
         /* Shut up the must_check tests - We don't care if this does not 
succeed */
         if (pci_set_mwi(pdev))
                 rvalue = 0;


Roger While



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re. Please pull 'upstream' branch of wireless-2.6
@ 2006-12-29 10:28 Roger While
  0 siblings, 0 replies; 6+ messages in thread
From: Roger While @ 2006-12-29 10:28 UTC (permalink / raw)
  To: netdev; +Cc: linville, jeff


> > Roy Marples (1):
> >       prism54: set carrier flags correctly
>
>Why is this not #upstream-fixes material?  What's the impact?

Actually, I think the patch is incorrect.
At best it is insufficient and at worst it
stops the driver working correctly.

I can't see why we do carrier_off after start_queue in the open.
Other drivers (eg. ipw2100) do carrier_on.

We should also look at other places where eg. stop_queue
is called and do a carrier_off eg. the close routine.
(Amongst others)

Also according to Documentation/networking/operstates.txt
(netif_carrier_on/off) -
"It is guaranteed that only the driver has write access,
  however, if different layers of the driver manipulate the same flag,
  the driver has to provide the synchronisation needed."

The trap routine in isl_ioctl.c however is lockless.
Assuming that the doc is correct, I would have thought
that putting carrier_on/off here is buggy or ?

Roger While



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re. Please pull 'upstream' branch of wireless-2.6
@ 2007-01-20 11:28 Roger While
  2007-01-20 22:35 ` John W. Linville
  0 siblings, 1 reply; 6+ messages in thread
From: Roger While @ 2007-01-20 11:28 UTC (permalink / raw)
  To: netdev; +Cc: linville, jeff


>Kai Engert (1):
>       prism54: add ethtool -i interface

I would have expected at least the firmware version to be reported
as well as the bus info.
(info->fw_version, info->bus_info)

Roger While



^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-01-20 23:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-08 17:27 Re. Please pull 'upstream' branch of wireless-2.6 Roger While
2006-11-08 19:46 ` John W. Linville
  -- strict thread matches above, loose matches on Subject: below --
2006-11-09  8:24 Roger While
2006-12-29 10:28 Roger While
2007-01-20 11:28 Roger While
2007-01-20 22:35 ` John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).