From: Al Viro <viro@ftp.linux.org.uk>
To: netdev@vger.kernel.org
Subject: why do we mangle checksums for v6 ICMP?
Date: Wed, 8 Nov 2006 22:13:32 +0000 [thread overview]
Message-ID: <20061108221332.GI29920@ftp.linux.org.uk> (raw)
AFAICS, the rules are:
(1) checksum is 16-bit one's complement of the one's complement sum of
relevant 16bit words.
(2) for v4 UDP all-zeroes has special meaning - no checksum; if you get
it from (1), send all-ones instead.
(3) for v6 UDP we have the same remapping as in (2), but all-zeroes has
different meaning - not "ignore checksum" as in v4, but "reject the
packet".
(4) there is no (4).
IOW, nobody except UDP has any business doing that 0->0xffff
replacement. However, we have
if (icmp6h->icmp6_cksum == 0)
icmp6h->icmp6_cksum = -1;
and similar in net/ipv6/raw.c
AFAICS, both went in with (commit ID by linux-hist repository)
commit 6bac90985c8b65ffc25839c001aa7ef4831d2915
Author: Kazunori Miyazawa <kazunori@miyazawa.org>
Date: Mon May 12 00:21:19 2003 -0700
[IPV4]: Introduce ip6_append_data.
That changeset has very similar changes done in udp.c, icmp.c and raw.c;
remapping of UDP checksum used to be in the area affected by the changeset
and it looks like it got not just preserved in udp.c (as it should), but
copied to icmp.c and raw.c instances.
So... is it really needed there?
next reply other threads:[~2006-11-08 22:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-08 22:13 Al Viro [this message]
2006-11-08 22:28 ` why do we mangle checksums for v6 ICMP? Al Viro
2006-11-09 17:32 ` Brian Haley
2006-11-09 23:14 ` David Miller
2006-11-10 16:24 ` [PATCH] IPv6: only modify checksum for UDP Brian Haley
2006-11-10 17:54 ` David Stevens
2006-11-14 0:50 ` David Miller
2006-11-14 1:18 ` Al Viro
2006-11-14 1:44 ` David Stevens
2006-11-14 1:52 ` Al Viro
2006-11-10 22:55 ` David Miller
2006-11-10 23:17 ` Nivedita Singhvi
2006-11-10 23:26 ` David Miller
2006-11-10 23:36 ` Nivedita Singhvi
2006-11-12 1:30 ` Brian Haley
2006-11-10 16:25 ` [PATCH] IPv6: optimize echo reply checksum calculation Brian Haley
2006-11-10 17:34 ` Al Viro
2006-11-10 17:51 ` Brian Haley
2006-11-10 18:05 ` Al Viro
2006-11-10 18:20 ` Al Viro
2006-11-10 19:04 ` Brian Haley
2006-11-10 19:17 ` Al Viro
2006-11-10 21:06 ` Brian Haley
2006-11-11 1:45 ` Al Viro
2006-11-11 18:07 ` why do we mangle checksums for v6 ICMP? Bill Fink
2006-11-13 7:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061108221332.GI29920@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).