From: David Miller <davem@davemloft.net>
To: sri@us.ibm.com
Cc: vladislav.yasevich@hp.com, mroos@linux.ee,
netdev@vger.kernel.org, lksctp-developers@lists.sourceforge.net
Subject: Re: [PATCH] warning in SCTP
Date: Thu, 09 Nov 2006 16:30:13 -0800 (PST) [thread overview]
Message-ID: <20061109.163013.115933634.davem@davemloft.net> (raw)
In-Reply-To: <1162492190.9660.28.camel@w-sridhar2.beaverton.ibm.com>
From: Sridhar Samudrala <sri@us.ibm.com>
Date: Thu, 02 Nov 2006 10:29:49 -0800
> On Thu, 2006-11-02 at 11:09 -0500, Vlad Yasevich wrote:
> > Meelis Roos wrote:
> > >> Actually, I'm backing this one out, it creates new warnings because
> > >> callers of this function pass in a "const" pointer.
> > >
> > > Yes, it now seems it's not so simple. Marking it non-const there would
> > > mark the it non-const in the whole family of sctp_state_fn_t and I'm not
> > > sure that's the best thing to do. I guess the maintainer has better
> > > bases for deciding what to do about it.
> > >
> >
> > An alternate solution would be to make the digest a pointer, allocate
> > it in sctp_endpoint_init() and free it in sctp_endpoint_destroy().
>
> I agree that this is a better solution.
>
> Acked-by: Sridhar Samudrala <sri@us.ibm.com>
Applied to net-2.6.20, thanks everyone.
prev parent reply other threads:[~2006-11-10 0:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 7:29 [PATCH] warning in SCTP Meelis Roos
2006-11-02 8:16 ` David Miller
2006-11-02 8:22 ` Meelis Roos
2006-11-02 8:30 ` Oleg Verych
2006-11-02 8:39 ` David Miller
2006-11-02 8:49 ` Meelis Roos
2006-11-02 9:12 ` Meelis Roos
2006-11-02 9:22 ` Meelis Roos
2006-11-02 16:09 ` Vlad Yasevich
2006-11-02 18:29 ` Sridhar Samudrala
2006-11-10 0:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061109.163013.115933634.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=mroos@linux.ee \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).