[PATCH] mark non-compiling ISA network drivers i386 only

[PATCH] mark non-compiling ISA network drivers i386 only

[Olaf Hering]

Provide drivers for the old toys only on i386
isa_bus_to_virt is defined only on i386, mips and arm
isa_virt_to_bus is used for floppy.ko

Add missing '&& ISA_DMA_API' to NI52

WARNING: "isa_bus_to_virt" [drivers/net/ni65.ko] undefined!
WARNING: "isa_virt_to_bus" [drivers/net/ni65.ko] undefined!
WARNING: "isa_bus_to_virt" [drivers/net/ni52.ko] undefined!
WARNING: "isa_bus_to_virt" [drivers/net/lance.ko] undefined!
WARNING: "isa_virt_to_bus" [drivers/net/lance.ko] undefined!
WARNING: "isa_bus_to_virt" [drivers/net/3c515.ko] undefined!
WARNING: "isa_virt_to_bus" [drivers/net/3c515.ko] undefined!
WARNING: "isa_virt_to_bus" [drivers/net/3c505.ko] undefined!

I'm sure noone will miss the drivers.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

---
 drivers/net/Kconfig |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Index: linux-2.6/drivers/net/Kconfig
===================================================================
--- linux-2.6.orig/drivers/net/Kconfig
+++ linux-2.6/drivers/net/Kconfig
@@ -616,7 +616,7 @@ config EL2
 
 config ELPLUS
 	tristate "3c505 \"EtherLink Plus\" support"
-	depends on NET_VENDOR_3COM && ISA && ISA_DMA_API
+	depends on NET_VENDOR_3COM && ISA && ISA_DMA_API && X86
 	---help---
 	  Information about this network (Ethernet) card can be found in
 	  <file:Documentation/networking/3c505.txt>.  If you have a card of
@@ -657,7 +657,7 @@ config EL3
 
 config 3C515
 	tristate "3c515 ISA \"Fast EtherLink\""
-	depends on NET_VENDOR_3COM && (ISA || EISA) && ISA_DMA_API
+	depends on NET_VENDOR_3COM && (ISA || EISA) && ISA_DMA_API && X86
 	help
 	  If you have a 3Com ISA EtherLink XL "Corkscrew" 3c515 Fast Ethernet
 	  network card, say Y and read the Ethernet-HOWTO, available from
@@ -735,7 +735,7 @@ config TYPHOON
 
 config LANCE
 	tristate "AMD LANCE and PCnet (AT1500 and NE2100) support"
-	depends on NET_ETHERNET && ISA && ISA_DMA_API
+	depends on NET_ETHERNET && ISA && ISA_DMA_API && X86
 	help
 	  If you have a network (Ethernet) card of this type, say Y and read
 	  the Ethernet-HOWTO, available from
@@ -918,7 +918,7 @@ config NI5010
 
 config NI52
 	tristate "NI5210 support"
-	depends on NET_VENDOR_RACAL && ISA
+	depends on NET_VENDOR_RACAL && ISA && ISA_DMA_API && X86
 	help
 	  If you have a network (Ethernet) card of this type, say Y and read
 	  the Ethernet-HOWTO, available from
@@ -930,7 +930,7 @@ config NI52
 
 config NI65
 	tristate "NI6510 support"
-	depends on NET_VENDOR_RACAL && ISA && ISA_DMA_API
+	depends on NET_VENDOR_RACAL && ISA && ISA_DMA_API && X86
 	help
 	  If you have a network (Ethernet) card of this type, say Y and read
 	  the Ethernet-HOWTO, available from

Re: [PATCH] mark non-compiling ISA network drivers i386 only

[Stephen Hemminger]

On Thu, 9 Nov 2006 19:40:21 +0100 (MET)
Olaf Hering <olaf@aepfle.de> wrote:

> 
> Provide drivers for the old toys only on i386
> isa_bus_to_virt is defined only on i386, mips and arm
> isa_virt_to_bus is used for floppy.ko

Why not mark all of ISA as i386, mips, arm only?

Re: [PATCH] mark non-compiling ISA network drivers i386 only

[Olaf Hering]

On Thu, Nov 09, Stephen Hemminger wrote:

> On Thu, 9 Nov 2006 19:40:21 +0100 (MET)
> Olaf Hering <olaf@aepfle.de> wrote:
> 
> > 
> > Provide drivers for the old toys only on i386
> > isa_bus_to_virt is defined only on i386, mips and arm
> > isa_virt_to_bus is used for floppy.ko
> 
> Why not mark all of ISA as i386, mips, arm only?

This patch is mainly for users of these 3 macros:

'(isa_virt_to_bus|isa_page_to_bus|isa_bus_to_virt)'

3c505.c 3c515.c 3c523.c 3c527.c aha1542.c cs89x0.c esp.c ibmmca.c
lance.c mca_53c9x.c ni52.c ni65.c ps2esdi.c ultrastor.c wd7000.c

I did not enable all of them in a ppc32 pmac config.
ppc32 PReP does have ISA slots on the motorola boards, no idea if anyone
really cares about ISA cards today.