From: David Miller <davem@davemloft.net>
To: gerrit@erg.abdn.ac.uk
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [TCP]: remove dead code in init_sequence
Date: Fri, 10 Nov 2006 14:07:02 -0800 (PST) [thread overview]
Message-ID: <20061110.140702.97293507.davem@davemloft.net> (raw)
In-Reply-To: <200611101204.31644@strip-the-willow>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Fri, 10 Nov 2006 12:04:31 +0000
> This removes two redundancies:
>
> 1) The test (skb->protocol == htons(ETH_P_IPV6) in tcp_v6_init_sequence()
> is always true, due to
> * tcp_v6_conn_request() is the only function calling this one
> * tcp_v6_conn_request() redirects all skb's with ETH_P_IP protocol to
> tcp_v4_conn_request() [ cf. top of tcp_v6_conn_request()]
>
> 2) The first argument, `struct sock *sk' of tcp_v{4,6}_init_sequence() is
> never used.
>
> Patch has been tested.
>
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Looks good, patch applied, thanks Gerrit.
prev parent reply other threads:[~2006-11-10 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 12:04 [PATCH] [TCP]: remove dead code in init_sequence Gerrit Renker
2006-11-10 22:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061110.140702.97293507.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox