From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] Spidernet - remove ETH_ZLEN check in earlier patch Date: Fri, 10 Nov 2006 09:58:02 -0800 Message-ID: <20061110095802.26854fea@freekitty> References: <1163181046.4422.11.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Jeff Garzik , Andrew Morton , netdev , Work Return-path: Received: from smtp.osdl.org ([65.172.181.4]:59562 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1161926AbWKJSH3 (ORCPT ); Fri, 10 Nov 2006 13:07:29 -0500 To: jim@jklewis.com In-Reply-To: <1163181046.4422.11.camel@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, 10 Nov 2006 11:50:46 -0600 Jim Lewis wrote: > Subject: Spidernet - remove ETH_ZLEN check in earlier patch > From: James K Lewis > > In an earlier patch, code was added to pad packets that were less that > ETH_ZLEN (60) bytes using the skb_pad function. This has caused hangs > when accessing certain NFS mounted file systems. This patch removes the > check and solves the NFS problem. The driver, with this patch, has been > tested extensively. Please apply. > > > Signed-off-by: James K Lewis Does the hardware do padding for you? The padding is important for the Ethernet spec, and for security reasons (random memory leakage). -- Stephen Hemminger