Re: [PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux

[Stephen Hemminger <shemminger@osdl.org>]

On Fri, 10 Nov 2006 14:38:46 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Fri, 10 Nov 2006 09:37:15 -0800
> 
> > On Fri, 10 Nov 2006 16:09:20 +0000
> > Gerrit Renker <gerrit@erg.abdn.ac.uk> wrote:
> > 
> > > [NET/IPv4]: Support for the UDP-Lite protocol (RFC 3828)
> > > 
> > > This adds support for UDP-Lite to the IPv4 stack, provided as an extension
> > > to the existing UDPv4 code:
> > > 	* generic routines are all located in net/ipv4/udp.c
> > > 	* UDP-Lite specific routines are in net/ipv4/udplite.c
> > > 	* MIB/statistics support in /proc/net/snmp and /proc/net/udplite
> > > 	* shared API with extensions for partial checksum coverage
> > > 	* consolidation of shared code
> > > 
> > > 
> > 
> > This code is does too much inlining (like existing network code).
> > Should it be made configurable?
> 
> It doesn't get built at all if you check his patches :-)
> 
> But once that's fixed up, I think we can fix that with a followon
> patch.  We've put Gerrit through the ringer enough on this stuff.

Agreed.  But we can do some code rearranging/deinlining early in 2.6.20

-- 
Stephen Hemminger <shemminger@osdl.org>